-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] Update dependency @types/fnv-plus to ^1.3.2 (main) (#205442) #205755
Conversation
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@types/fnv-plus](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/fnv-plus) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/fnv-plus)) | devDependencies | patch | [`^1.3.0` -> `^1.3.2`](https://renovatebot.com/diffs/npm/@types%2ffnv-plus/1.3.0/1.3.2) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJiYWNrcG9ydDphbGwtb3BlbiIsInJlbGVhc2Vfbm90ZTpza2lwIl19--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Sergi Romeu <[email protected]> (cherry picked from commit f57ce30) # Conflicts: # package.json # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Do we need this backport to 7.17 - is the dependency used here as it looks like it's introduced in this PR based on the diff 🤔
💔 Build Failed
Failed CI StepsMetrics [docs]
History |
@jennypavlova It seemed the renovate generated PR was trying to backport this to |
@Bluefinger That's strange, why would it update something that doesn't exist in this version 🤔 I just don't see a reason to include a dependency if it's not used here or am I missing something? I wound rather change the label of the initial renovate PR from |
@jennypavlova Well, I wasn't aware it wasn't part of 7.17, so honestly, I don't think it will matter much if it continues to not have the dependency 😄 I'll just change the label and close out this PR |
Pull request was closed
Backport
This will backport the following commits from
main
to7.17
:Questions ?
Please refer to the Backport tool documentation
This PR contains the following updates:
^1.3.0
->^1.3.2