Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKA: Categorise remaining packages #205875

Merged
merged 5 commits into from
Jan 8, 2025
Merged

SKA: Categorise remaining packages #205875

merged 5 commits into from
Jan 8, 2025

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Jan 8, 2025 •
edited by kibanamachine
Loading

Summary

  • Delete unused package @kbn/formatters
  • Delete unused package @kbn/response-ops-feature-flag-service
  • Flag @kbn/generate-console-definitions as devOnly: true
  • Flag @kbn/plugin-check as devOnly: true
  • Flag @kbn/set-map as devOnly: true
  • Flag @kbn/synthetics-private-location as devOnly: true
  • Categorise @kbn/calculate-auto as platform/shared
  • Categorise @kbn/charts-theme as platform/shared
  • Categorise @kbn/saved-search-component as platform/shared
  • Categorise @kbn/use-tracked-promise as platform/shared
  • Categorise @kbn/charts-theme as platform/shared
  • Categorise @kbn/response-ops-rule-form as platform/shared

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 8, 2025
@gsoldevila gsoldevila marked this pull request as ready for review January 8, 2025 12:18
@gsoldevila gsoldevila requested review from a team as code owners January 8, 2025 12:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Jan 8, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

yngrdyn
yngrdyn approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-logs-team changes LGTM ✨

sabarasaba
sabarasaba approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-management changes lgtm

@gsoldevila gsoldevila requested a review from a team as a code owner January 8, 2025 16:51
ThomThomson
ThomThomson approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbn-grid-layout categorization LGTM!

jbudz
jbudz approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-set-map/kibana.jsonc LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/formatters 3 - -3
@kbn/response-ops-feature-flag-service 3 - -3
total -6
Unknown metric groups

API count

id before after diff
@kbn/formatters 3 - -3
@kbn/response-ops-feature-flag-service 3 - -3
total -6

History

@gsoldevila gsoldevila merged commit 2be928c into elastic:main Jan 8, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12679235104

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- Sustainable Kibana Architecture: Move CodeEditor related packages #205587 (#205738)
- [Streams] Dashboard linking (#204309)
- Make saved_objects_tagging plugin shared (#205695)
- [Stack Connectors][Microsoft Defender] Adds new connector for Microsoft Defender for Endpoint (#203183)

Manual backport

To create the backport manually run:

node scripts/backport --pr 205875

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Jan 8, 2025
@gsoldevila
SKA: Categorise remaining packages (elastic#205875)
4f4a58e 
## Summary

* Delete unused package `@kbn/formatters`
* Delete unused package `@kbn/response-ops-feature-flag-service`
* Flag `@kbn/generate-console-definitions` as `devOnly: true`
* Flag `@kbn/plugin-check` as `devOnly: true`
* Flag `@kbn/set-map` as `devOnly: true`
* Flag `@kbn/synthetics-private-location` as `devOnly: true`
* Categorise `@kbn/calculate-auto` as `platform/shared`
* Categorise `@kbn/charts-theme` as `platform/shared`
* Categorise `@kbn/saved-search-component` as `platform/shared`
* Categorise `@kbn/use-tracked-promise` as `platform/shared`
* Categorise `@kbn/charts-theme` as `platform/shared`
* Categorise `@kbn/response-ops-rule-form` as `platform/shared`

(cherry picked from commit 2be928c)

# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-charts-theme/kibana.jsonc
#	packages/kbn-palettes/kibana.jsonc
@gsoldevila gsoldevila mentioned this pull request Jan 8, 2025
Merged
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit that referenced this pull request Jan 8, 2025
@gsoldevila
[8.x] SKA: Categorise remaining packages (#205875) (#205973)
935d2e1 
# Backport

This will backport the following commits from `main` to `8.x`:
- [SKA: Categorise remaining packages
(#205875)](#205875)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T21:20:14Z","message":"SKA:
Categorise remaining packages (#205875)\n\n## Summary\r\n\r\n* Delete
unused package `@kbn/formatters`\r\n* Delete unused package
`@kbn/response-ops-feature-flag-service`\r\n* Flag
`@kbn/generate-console-definitions` as `devOnly: true`\r\n* Flag
`@kbn/plugin-check` as `devOnly: true`\r\n* Flag `@kbn/set-map` as
`devOnly: true`\r\n* Flag `@kbn/synthetics-private-location` as
`devOnly: true`\r\n* Categorise `@kbn/calculate-auto` as
`platform/shared`\r\n* Categorise `@kbn/charts-theme` as
`platform/shared`\r\n* Categorise `@kbn/saved-search-component` as
`platform/shared`\r\n* Categorise `@kbn/use-tracked-promise` as
`platform/shared`\r\n* Categorise `@kbn/charts-theme` as
`platform/shared`\r\n* Categorise `@kbn/response-ops-rule-form` as
`platform/shared`","sha":"2be928c489601fac46ce1e5136ed9ecc63fd4e22","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-management"],"number":205875,"url":"https://github.com/elastic/kibana/pull/205875","mergeCommit":{"message":"SKA:
Categorise remaining packages (#205875)\n\n## Summary\r\n\r\n* Delete
unused package `@kbn/formatters`\r\n* Delete unused package
`@kbn/response-ops-feature-flag-service`\r\n* Flag
`@kbn/generate-console-definitions` as `devOnly: true`\r\n* Flag
`@kbn/plugin-check` as `devOnly: true`\r\n* Flag `@kbn/set-map` as
`devOnly: true`\r\n* Flag `@kbn/synthetics-private-location` as
`devOnly: true`\r\n* Categorise `@kbn/calculate-auto` as
`platform/shared`\r\n* Categorise `@kbn/charts-theme` as
`platform/shared`\r\n* Categorise `@kbn/saved-search-component` as
`platform/shared`\r\n* Categorise `@kbn/use-tracked-promise` as
`platform/shared`\r\n* Categorise `@kbn/charts-theme` as
`platform/shared`\r\n* Categorise `@kbn/response-ops-rule-form` as
`platform/shared`","sha":"2be928c489601fac46ce1e5136ed9ecc63fd4e22"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205875","number":205875,"mergeCommit":{"message":"SKA:
Categorise remaining packages (#205875)\n\n## Summary\r\n\r\n* Delete
unused package `@kbn/formatters`\r\n* Delete unused package
`@kbn/response-ops-feature-flag-service`\r\n* Flag
`@kbn/generate-console-definitions` as `devOnly: true`\r\n* Flag
`@kbn/plugin-check` as `devOnly: true`\r\n* Flag `@kbn/set-map` as
`devOnly: true`\r\n* Flag `@kbn/synthetics-private-location` as
`devOnly: true`\r\n* Categorise `@kbn/calculate-auto` as
`platform/shared`\r\n* Categorise `@kbn/charts-theme` as
`platform/shared`\r\n* Categorise `@kbn/saved-search-component` as
`platform/shared`\r\n* Categorise `@kbn/use-tracked-promise` as
`platform/shared`\r\n* Categorise `@kbn/charts-theme` as
`platform/shared`\r\n* Categorise `@kbn/response-ops-rule-form` as
`platform/shared`","sha":"2be928c489601fac46ce1e5136ed9ecc63fd4e22"}}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@gsoldevila @CAWilson94
SKA: Categorise remaining packages (elastic#205875)
fd1e60b 
## Summary

* Delete unused package `@kbn/formatters`
* Delete unused package `@kbn/response-ops-feature-flag-service`
* Flag `@kbn/generate-console-definitions` as `devOnly: true`
* Flag `@kbn/plugin-check` as `devOnly: true`
* Flag `@kbn/set-map` as `devOnly: true`
* Flag `@kbn/synthetics-private-location` as `devOnly: true`
* Categorise `@kbn/calculate-auto` as `platform/shared`
* Categorise `@kbn/charts-theme` as `platform/shared`
* Categorise `@kbn/saved-search-component` as `platform/shared`
* Categorise `@kbn/use-tracked-promise` as `platform/shared`
* Categorise `@kbn/charts-theme` as `platform/shared`
* Categorise `@kbn/response-ops-rule-form` as `platform/shared`
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@gsoldevila @viduni94
SKA: Categorise remaining packages (elastic#205875)
6036a56 
## Summary

* Delete unused package `@kbn/formatters`
* Delete unused package `@kbn/response-ops-feature-flag-service`
* Flag `@kbn/generate-console-definitions` as `devOnly: true`
* Flag `@kbn/plugin-check` as `devOnly: true`
* Flag `@kbn/set-map` as `devOnly: true`
* Flag `@kbn/synthetics-private-location` as `devOnly: true`
* Categorise `@kbn/calculate-auto` as `platform/shared`
* Categorise `@kbn/charts-theme` as `platform/shared`
* Categorise `@kbn/saved-search-component` as `platform/shared`
* Categorise `@kbn/use-tracked-promise` as `platform/shared`
* Categorise `@kbn/charts-theme` as `platform/shared`
* Categorise `@kbn/response-ops-rule-form` as `platform/shared`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

@cnasikas cnasikas cnasikas approved these changes

@Dosant Dosant Dosant approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

@markov00 markov00 markov00 approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:obs-ux-management Observability Management User Experience Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.