Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [ECO][Inventory v2] Remove the landing page to enable the entity model (#205534) #205958

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[8.x] [ECO][Inventory v2] Remove the landing page to enable the entity model (#205534) #205958

merged 1 commit into from
Jan 8, 2025
+5 −476

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@jennypavlova
[ECO][Inventory v2] Remove the landing page to enable the entity model (
ab9cf56 
elastic#205534)

Closes elastic#203095
Closes elastic#204263

## Summary

This PR removes the page for the enabling functionality and welcome
screen. After the migration to v2 API we don't need to enable it anymore
as we are not using transforms

### Before:

![image](https://github.com/user-attachments/assets/0c8d5841-9189-4551-a1be-87801cfcf57d)

![image](https://github.com/user-attachments/assets/75a73dd8-6b16-452b-abcf-41e1fcca6645)

### After:
The same without the extra step to enable the entities and the welcome
screen:
- No data:

![image](https://github.com/user-attachments/assets/dbfdf501-36e7-4b6f-a8b6-ed0a6748ab62)

- With data:

![image](https://github.com/user-attachments/assets/0bbb2983-4e0a-477c-ac11-d2256b5ff854)

## Testing

- In a local environment enable the entities feature flag ( it should be
a clean env as the entities should not be enabled before ):
<img width="1911" alt="image"
src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e"
/>

- Go to Inventory
- Check before and after ingesting data
- Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this
case can't be checked before
elastic#203452 is merged~ -
elastic#203452 is merged 🎉

(cherry picked from commit d6e28f7)
@kibanamachine kibanamachine enabled auto-merge (squash) January 8, 2025 19:35
@kibanamachine kibanamachine mentioned this pull request Jan 8, 2025
Merged
@kibanamachine kibanamachine merged commit 61aa939 into elastic:8.x Jan 8, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #19 / step select agent policy should select first agent policy by default if multiple exists
  • [job] [logs] Jest Tests #19 / Test packages All test packages should be valid (node scripts/verify_test_packages)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 238 231 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 231.7KB 225.2KB -6.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
inventory 13.0KB 12.8KB -144.0B
Unknown metric groups

miscellaneous assets size

id before after diff
inventory 1.1MB 761.8KB -351.7KB

cc @jennypavlova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @jennypavlova