🌊 Fix ascendants check #206080
Merged
🌊 Fix ascendants check #206080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
|
simianhacker
approved these changes
Jan 9, 2025
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 task
flash1293
added
backport:version
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
flash1293
added
backport:version
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 13, 2025
The id->name refactoring didn't catch the check for ascendants which was still looking for id. This PR fixes this (cherry picked from commit 23c958c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 13, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [🌊 Fix ascendants check (#206080)](#206080) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T15:48:13Z","message":"🌊 Fix ascendants check (#206080)\n\nThe id->name refactoring didn't catch the check for ascendants which was\r\nstill looking for id. This PR fixes this","sha":"23c958c1a1330f29d9d4b55db305db81a069106b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.18.0","Feature:Streams"],"title":"🌊 Fix ascendants check","number":206080,"url":"https://github.com/elastic/kibana/pull/206080","mergeCommit":{"message":"🌊 Fix ascendants check (#206080)\n\nThe id->name refactoring didn't catch the check for ascendants which was\r\nstill looking for id. This PR fixes this","sha":"23c958c1a1330f29d9d4b55db305db81a069106b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206080","number":206080,"mergeCommit":{"message":"🌊 Fix ascendants check (#206080)\n\nThe id->name refactoring didn't catch the check for ascendants which was\r\nstill looking for id. This PR fixes this","sha":"23c958c1a1330f29d9d4b55db305db81a069106b"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Joe Reuter <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
The id->name refactoring didn't catch the check for ascendants which was still looking for id. This PR fixes this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id->name refactoring didn't catch the check for ascendants which was still looking for id. This PR fixes this