Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues #206651

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues #206651

wants to merge 4 commits into from
+8 −14

Conversation

Bluefinger
Copy link
Contributor

@Bluefinger Bluefinger commented Jan 14, 2025 •
edited
Loading

Summary

cytoscape released yet another semver breaking change, affecting typing once more in a couple of places. They now have their own index.d.ts file for Typescript support, but this causes some issues as they don't always have the same type name as the @types version. Had to fix in a couple of places, both in APM and in ML codebases.

Supersedes #206498

How to test

  • This PR passes the CI with no typing issues, or failed tests
  • Going to APM or ML pages with cytoscape being loaded shows no regressions.

@Bluefinger Bluefinger added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:all-open Backport to all branches that could still receive a release Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jan 14, 2025
@Bluefinger Bluefinger requested review from a team as code owners January 14, 2025 17:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 15, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.9MB 4.0MB +76.9KB
ml 4.7MB 4.8MB +38.4KB
total +115.3KB

History

alvarezmelissa87
alvarezmelissa87 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bluefinger @elasticmachine @alvarezmelissa87