[Fleet] set workerIdleMemoryLimit for jest server tests #206684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
added
release_note:skip
kpollich
approved these changes
Jan 14, 2025
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @nchaulet |
|
@elasticmachine merge upstream |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 15, 2025
(cherry picked from commit bc47ff0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 15, 2025
… (#206808) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] set workerIdleMemoryLimit for jest server tests (#206684)](#206684) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-15T15:19:25Z","message":"[Fleet] set workerIdleMemoryLimit for jest server tests (#206684)","sha":"bc47ff03b5fb5ec282a89290120b3f5a1e644bb4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] set workerIdleMemoryLimit for jest server tests","number":206684,"url":"https://github.com/elastic/kibana/pull/206684","mergeCommit":{"message":"[Fleet] set workerIdleMemoryLimit for jest server tests (#206684)","sha":"bc47ff03b5fb5ec282a89290120b3f5a1e644bb4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206684","number":206684,"mergeCommit":{"message":"[Fleet] set workerIdleMemoryLimit for jest server tests (#206684)","sha":"bc47ff03b5fb5ec282a89290120b3f5a1e644bb4"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://github.com/elastic/ingest-dev/issues/4683
We had a new failure due to a timeout in server unit tests, that PR try to use the
workerIdleMemoryLimitso we do not reuse the same worker and avoid to put too much memory pressure (and eventually large GC operation) during unit tests.running jest locally with runInBand and logHeapUsage you can see the difference on how memory grow
With
workerIdleMemoryLimitWithout
workerIdleMemoryLimitShould avoid timeout like this one #206681