Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chrome] Improve breadcrumb extension #209765

Merged
merged 3 commits into from
Feb 7, 2025
Merged

[chrome] Improve breadcrumb extension #209765

merged 3 commits into from
Feb 7, 2025

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Feb 5, 2025 •
edited by kibanamachine
Loading

Summary

fix #208728

This PR improves breadcrumb extension point for adding starring next to a dashboard breadcrumb #200315:

  • Fix breadcrumb extension didn't render in solution nav
  • Support multiple extensions (search sessions are deprecated and need to be enabled with kibana.yml flag, but we still need to support both UI elements)
  • Improve DX to unmount the extension

To test:

  • Add data.search.sessions.enabled: true and see that search session UI appears in solution nav.
  • To test multiple, add more extensions by using chrome.setBreadcrumbsAppendExtension, e.g. in src/platform/plugins/shared/data/public/search/search_service.ts . This actually gonna be used in [Dashboards] Favorite a dashboard from within #200315

Screenshot 2025-02-05 at 14 41 21

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) labels Feb 5, 2025
@Dosant Dosant marked this pull request as ready for review February 5, 2025 13:52
@Dosant Dosant requested review from a team as code owners February 5, 2025 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant requested a review from tsullivan February 5, 2025 13:52
@Dosant Dosant added backport:version Backport to applied version labels v8.19.0 labels Feb 5, 2025
tsullivan
tsullivan approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a slew of improvements!

@Dosant
Merge branch 'main' of github.com:elastic/kibana into d/2025-02-05-im…
b33f5af 
…prove-breadcrumb-extension

# Conflicts:
#	x-pack/solutions/observability/plugins/observability_logs_explorer/public/components/logs_explorer_top_nav_menu.tsx
@jennypavlova jennypavlova self-requested a review February 7, 2025 13:39
jennypavlova
jennypavlova approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs ux infra and services changes LGTM

@Dosant Dosant enabled auto-merge (squash) February 7, 2025 14:45
@Dosant Dosant merged commit 02a88d1 into elastic:main Feb 7, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13202204703

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group8.ts / lens serverless - group 1 - subgroup 6 lens logsdb smoke testing functions support Scenarios with changing stream type LogsDB downgraded to regular data stream scenarios LogsDB stream with no additional stream/index and no host.name field should visualize an annotation layer from a logsDB stream using another time field

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 406 407 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 295.7KB 295.7KB -10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 484.3KB 484.8KB +512.0B
observabilityShared 93.9KB 93.9KB -10.0B
total +502.0B
Unknown metric groups

API count

id before after diff
@kbn/core-chrome-browser 210 211 +1

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Security Solution] [AI Assistant] Replace polynomial regular expression with constant time string manipulation (#209314)
- [Expandable Flyout] - customize default right, left and preview widths for push mode (#206155)
- [Security Solution] remove isDraggable props + various related cleanups (#207959)
- [GenAI Connectors] Add support for telemetry metadata (#208180)

Manual backport

To create the backport manually run:

node scripts/backport --pr 209765

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 10, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 209765 locally

@Dosant Dosant removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels v8.19.0 labels Feb 10, 2025
@kibanamachine kibanamachine added backport:skip This commit does not require backporting labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@miltonhultgren miltonhultgren miltonhultgren approved these changes

@jloleysens jloleysens jloleysens approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix BreadcrumbAppendExtension in solution nav
8 participants
@Dosant @elasticmachine @kibanamachine @tsullivan @miltonhultgren @jloleysens @jennypavlova @tonyghiani