Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Reporting] Convert plugin setup and start to synchronous (#68326) #68932

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

tsullivan
Copy link
Member

Backports the following commits to 7.x:

)

* [Reporting] Convert plugin setup and start to synchronous

* revert class conversion

* diff prettify

* Fix test mocks + add some plugin async helpers where needed

* no setupReady startReady needed

* Add plugin test for sync/error cases

* PR feedback on tests/setup logs

* rename symbol

Co-authored-by: Joel Griffith <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit cc9c54e into elastic:7.x Jun 11, 2020
@tsullivan tsullivan deleted the backport/7.x/pr-68326 branch June 11, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants