Improve warning for insufficient file resources for PQ max_bytes #16656
+222
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
donoghuc
force-pushed
the
GH-14839-disk-usage
branch
from
557a159 to
9b408b4
Compare
|
yaauie
approved these changes
Mar 4, 2025
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
This commit refactors the `PersistedQueueConfigValidator` class to provide a more detailed, accurate and actionable warning when pipeline's PQ configs are at risk of running out of disk space. See elastic#14839 for design considerations. The highlights of the changes include accurately determining the free resources on a filesystem disk and then providing a breakdown of the usage for each of the paths configured for a queue.
donoghuc
force-pushed
the
GH-14839-disk-usage
branch
from
9b408b4 to
9013a1f
Compare
|
Thanks for the review! I just rebased and force pushed just to see it run in CI given its pretty old now 😅 |
|
💚 Build Succeeded
History
|
|
Tests are green. |
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
) This commit refactors the `PersistedQueueConfigValidator` class to provide a more detailed, accurate and actionable warning when pipeline's PQ configs are at risk of running out of disk space. See #14839 for design considerations. The highlights of the changes include accurately determining the free resources on a filesystem disk and then providing a breakdown of the usage for each of the paths configured for a queue. (cherry picked from commit 0621544)
Merged
5 tasks
donoghuc
added a commit
that referenced
this pull request
Mar 5, 2025
) (#17222) This commit refactors the `PersistedQueueConfigValidator` class to provide a more detailed, accurate and actionable warning when pipeline's PQ configs are at risk of running out of disk space. See #14839 for design considerations. The highlights of the changes include accurately determining the free resources on a filesystem disk and then providing a breakdown of the usage for each of the paths configured for a queue. (cherry picked from commit 0621544) Co-authored-by: Cas Donoghue <[email protected]>
|
@Mergifyio backport 9.0 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
) This commit refactors the `PersistedQueueConfigValidator` class to provide a more detailed, accurate and actionable warning when pipeline's PQ configs are at risk of running out of disk space. See #14839 for design considerations. The highlights of the changes include accurately determining the free resources on a filesystem disk and then providing a breakdown of the usage for each of the paths configured for a queue. (cherry picked from commit 0621544)
5 tasks
donoghuc
added a commit
that referenced
this pull request
Mar 5, 2025
) (#17249) This commit refactors the `PersistedQueueConfigValidator` class to provide a more detailed, accurate and actionable warning when pipeline's PQ configs are at risk of running out of disk space. See #14839 for design considerations. The highlights of the changes include accurately determining the free resources on a filesystem disk and then providing a breakdown of the usage for each of the paths configured for a queue. (cherry picked from commit 0621544) Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[Release Notes] Improve warning message for insufficient disk space when configuring persistent queues for pipelines.
What does this PR do?
This commit refactors the
PersistedQueueConfigValidatorclass to provide amore detailed, accurate and actionable warning when pipeline's PQ configs are at
risk of running out of disk space. See
#14839 for design considerations. The
highlights of the changes include accurately determining the free resources on a
filesystem disk and then providing a breakdown of the usage for each of the
paths configured for a queue.
Why is it important/What is the impact to the user?
The user will now have a much more detailed and accurate warning they can meaninfully take action with. Here is an example output (as generated using test mocks in the unit tests)
Checklist
Author's Checklist
How to test this PR locally
The unit tests should cover the basics, though i've extensively stubbed the filesystem I will be looking at standing this up in a real build.
Related issues
Use cases
Screenshots
Logs