Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] add test to verify that BufferedTokenizerExt doesn't apply enc… #16690

Closed

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Nov 19, 2024

…oding twice

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@andsel andsel self-assigned this Nov 19, 2024
Copy link

…w implementation of BufferedTokenizerExt, due to JRuby conversion of types
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 19, 2024

Copy link

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
Copy link

mergify bot commented Mar 5, 2025

This pull request is now in conflicts. Could you fix it @andsel? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b andsel/test_buftok_respect_charset_encoding upstream/andsel/test_buftok_respect_charset_encoding
git merge upstream/main
git push upstream andsel/test_buftok_respect_charset_encoding

@andsel
Copy link
Contributor Author

andsel commented Mar 6, 2025

Code added in #16968

@andsel andsel closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants