Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump lock file for 8.17 #17015

Closed
wants to merge 1 commit into from
Closed

bump lock file for 8.17 #17015

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2025

No description provided.

Comment on lines 881 to +883
java
universal-java-11
universal-java-17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbavey spidey-senses:

  • you introduced LogStash::Bundler::genericise_platform a while ago, and hooked into it with the plugin manager's install/update/remove commands. I remember that the effect was to ensure java platform was here and that the other specific ones were not present, but I don't recall why we needed to do it.
  • the current lockfile already has universal-java-11 (should it?), and this PR adds universal-java-11 (does this have net-negative effect?).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add to it, and I'm surprised that universal-java-11 is there too. Given that it has been here since 8.14, it likely isn't doing any harm, but I don't see a good reason to add universal-java-17.

I don't recall the why - I will investigate when I have a moment today

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@jsvd
Copy link
Member

jsvd commented Feb 5, 2025

@yaauie please rerun to capture the latest patch releases of http/beats/tcp inputs that introduce proper naming of netty threads.

@@ -322,7 +322,7 @@ GEM
lru_redux (~> 1.1.0)
logstash-filter-drop (3.0.5)
logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-filter-elastic_integration (8.17.0-java)
logstash-filter-elastic_integration (8.17.1-java)
logstash-core (>= 8.7.0)
logstash-core-plugin-api (>= 1.60, <= 2.99)
logstash-filter-elasticsearch (3.16.2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logstash-filter-elasticsearch (3.16.2)
logstash-filter-elasticsearch (3.17.0)

Can we please update the elasticsearch minor to include custom headers change

Comment on lines 881 to +883
java
universal-java-11
universal-java-17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add to it, and I'm surprised that universal-java-11 is there too. Given that it has been here since 8.14, it likely isn't doing any harm, but I don't see a good reason to add universal-java-17.

I don't recall the why - I will investigate when I have a moment today

@yaauie
Copy link
Member

yaauie commented Feb 5, 2025

superceded by #17024

@yaauie yaauie closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants