-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump lock file for 8.17 #17015
bump lock file for 8.17 #17015
Conversation
java | ||
universal-java-11 | ||
universal-java-17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robbavey spidey-senses:
- you introduced
LogStash::Bundler::genericise_platform
a while ago, and hooked into it with the plugin manager's install/update/remove commands. I remember that the effect was to ensurejava
platform was here and that the other specific ones were not present, but I don't recall why we needed to do it. - the current lockfile already has
universal-java-11
(should it?), and this PR addsuniversal-java-11
(does this have net-negative effect?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to add to it, and I'm surprised that universal-java-11
is there too. Given that it has been here since 8.14
, it likely isn't doing any harm, but I don't see a good reason to add universal-java-17
.
I don't recall the why - I will investigate when I have a moment today
|
💚 Build Succeeded
|
@yaauie please rerun to capture the latest patch releases of http/beats/tcp inputs that introduce proper naming of netty threads. |
@@ -322,7 +322,7 @@ GEM | |||
lru_redux (~> 1.1.0) | |||
logstash-filter-drop (3.0.5) | |||
logstash-core-plugin-api (>= 1.60, <= 2.99) | |||
logstash-filter-elastic_integration (8.17.0-java) | |||
logstash-filter-elastic_integration (8.17.1-java) | |||
logstash-core (>= 8.7.0) | |||
logstash-core-plugin-api (>= 1.60, <= 2.99) | |||
logstash-filter-elasticsearch (3.16.2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logstash-filter-elasticsearch (3.16.2) | |
logstash-filter-elasticsearch (3.17.0) |
Can we please update the elasticsearch minor to include custom headers change
java | ||
universal-java-11 | ||
universal-java-17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to add to it, and I'm surprised that universal-java-11
is there too. Given that it has been here since 8.14
, it likely isn't doing any harm, but I don't see a good reason to add universal-java-17
.
I don't recall the why - I will investigate when I have a moment today
superceded by #17024 |
No description provided.