Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move fips-mode gradle hooks to x-pack #17033

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Feb 6, 2025

Suggestion for #17029 to move all the gradle bits for the internal/observabilitySRE into x-pack.

@yaauie yaauie force-pushed the fips-mode-hooks-all-in-xpack branch from f285113 to 8d77b38 Compare February 6, 2025 22:26
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 6, 2025

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@donoghuc
Copy link
Member

donoghuc commented Feb 6, 2025

This looks promising! I just put your commit on top of mine to see it in CI. Locally I ran a test invocation in debug mode and see the debug message:

2025-02-06T22:42:53.386+0000 [DEBUG] [org.gradle.api.Task] configuring task ':logstash-core-benchmarks:test' to run in FIPSMode

At debug level it is claiming to apply those to all Test tasks, But i think that is OK as we will only ever combine setting -PrunTestsInFIPSMode=true when we explicitly want to run a test task.

@donoghuc donoghuc deleted the branch elastic:fips-unit-tests-poc February 7, 2025 17:37
@donoghuc donoghuc closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants