Reimplement LogStash::Numeric setting in Java #17127
Merged
+136
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are floats to use interval.
andsel
force-pushed
the
feature/numeric_setting_to_java_revisited
branch
from
540bc2a to
1cccfab
Compare
andsel
changed the title
18 tasks
edmocosta
reviewed
Feb 27, 2025
| } | ||
|
|
||
| @Override | ||
| public Number coerce(Object obj) { |
There was a problem hiding this comment.
It seems the Ruby's version is handling nil obj values, don't we need to do the same here for null?
There was a problem hiding this comment.
From irb REPL on previous code I got:
> s.coerce(nil)
/Users/andrea/workspace/logstash_andsel/logstash-core/lib/logstash/settings.rb:430:in `coerce': Failed to coerce value to Numeric. Received (NilClass) (ArgumentError)
so you are suggesting to add something
@Override
public Number coerce(Object obj) {
if (obj == null) {
throw new IllegalArgumentException("Failed to coerce value to SettingNumeric. Received null");
}
...
}There was a problem hiding this comment.
yes, something like that, so we don't get a NPE (obj.toString()) instead of an IllegalArgumentException when the value is null.
|
|
This pull request does not have a backport label. Could you fix it @andsel? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
Reimplements `LogStash::Setting::Numeric` Ruby setting class into the `org.logstash.settings.NumericSetting` and exposes it through `java_import` as `LogStash::Setting::NumericSetting`. Updates the rspec tests: - verifies `java.lang.IllegalArgumentException` instead of `ArgumentError` is thrown because the kind of exception thrown by Java code, during verification. (cherry picked from commit 07a3c8e)
3 tasks
andsel
added a commit
that referenced
this pull request
Mar 6, 2025
…#17273) This is an automatic backport of pull request #17127 done by [Mergify](https://mergify.com). ---- * Reimplement LogStash::Numeric setting in Java (#17127) Reimplements `LogStash::Setting::Numeric` Ruby setting class into the `org.logstash.settings.NumericSetting` and exposes it through `java_import` as `LogStash::Setting::NumericSetting`. Updates the rspec tests: - verifies `java.lang.IllegalArgumentException` instead of `ArgumentError` is thrown because the kind of exception thrown by Java code, during verification. (cherry picked from commit 07a3c8e) * Fixed reference of SettingNumeric class (on main modules were removed) --------- Co-authored-by: Andrea Selva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Reimplements
LogStash::Setting::NumericRuby setting class into theorg.logstash.settings.NumericSettingand exposes it throughjava_importasLogStash::Setting::NumericSetting.Updates the rspec tests:
java.lang.IllegalArgumentExceptioninstead ofArgumentErroris thrown because the kind of exception thrown by Java code, during verification.Why is it important/What is the impact to the user?
As a developer I want use Java classes to shape the configuration settings.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Update a numeric settings like
pipeline.batch.delayto a value that's not the default, start Logstash and verify that the setting value is used, for example check withRelated issues