Pluginmanager install preserve #17267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @yaauie? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
|
💚 Build Succeeded
|
donoghuc
approved these changes
Mar 6, 2025
|
This pull request does not have a backport label. Could you fix it @yaauie? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
* tests: integration tests for pluginmanager install --preserve * fix regression where pluginmanager's install --preserve flag didn't (cherry picked from commit a736178) # Conflicts: # qa/integration/specs/cli/install_spec.rb # qa/integration/specs/cli/pluginmanager_spec_helper.rb
3 tasks
yaauie
added a commit
to yaauie/logstash
that referenced
this pull request
Mar 6, 2025
* tests: integration tests for pluginmanager install --preserve * fix regression where pluginmanager's install --preserve flag didn't
yaauie
added a commit
to yaauie/logstash
that referenced
this pull request
Mar 6, 2025
* tests: integration tests for pluginmanager install --preserve * fix regression where pluginmanager's install --preserve flag didn't
This was referenced Mar 6, 2025
yaauie
added a commit
to yaauie/logstash
that referenced
this pull request
Mar 6, 2025
* tests: integration tests for pluginmanager install --preserve * fix regression where pluginmanager's install --preserve flag didn't
3 tasks
donoghuc
pushed a commit
that referenced
this pull request
Mar 6, 2025
* Pluginmanager clean after mutate (#17203) * pluginmanager: always clean after mutate * pluginmanager: don't skip updating plugins installed with --version * pr feedback (cherry picked from commit 8c96913) * Pluginmanager install preserve (#17267) * tests: integration tests for pluginmanager install --preserve * fix regression where pluginmanager's install --preserve flag didn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Fixes a regression introduced in #17203 that caused the
bin/logstash-plugin install --preserveflag to not preserve.Why is it important/What is the impact to the user?
--version, theGemfileis amended to add the plugin and its version requirement.--preserveflag should preserve the requirement.--versionto be upgraded had the side-effect of making the install command's--preservenot work.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
This PR comes with tests and a fix separately. The tests can be used to verify the pre-broken behaviour as so:
back-out the portion of the breaking commit