Fix browser project monitor alert config #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon: |
|
This pull request does not have a backport label. Could you fix it @paulb-elastic? 🙏
|
mergify
bot
added
the
backport-skip
|
This pull request is now in conflict. Could you fix it @paulb-elastic? 🙏 |
colleenmcginnis
added
backport-8.10
|
👋 @paulb-elastic is this PR ready to merge or are you still waiting on feedback from someone on your team? |
|
Thanks @colleenmcginnis sorry for the delay |
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
(cherry picked from commit 653bbdd) # Conflicts: # docs/en/observability/synthetics-configuration.asciidoc
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
(cherry picked from commit 653bbdd)
This was referenced Nov 9, 2023
colleenmcginnis
pushed a commit
that referenced
this pull request
Nov 13, 2023
(cherry picked from commit 653bbdd) Co-authored-by: Paul Bianciardi <[email protected]>
colleenmcginnis
added a commit
that referenced
this pull request
Nov 13, 2023
* Fix browser project monitor alert config (#3300) (cherry picked from commit 653bbdd) # Conflicts: # docs/en/observability/synthetics-configuration.asciidoc * fix merge conflict --------- Co-authored-by: Paul Bianciardi <[email protected]> Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
alertconfig was showing the YML syntax (that's already documented in https://www.elastic.co/guide/en/observability/current/synthetics-lightweight.html#synthetics-lightweight-common-options), which is not valid for browser monitors. Have removed TLS as that's not available today for browser monitors.