Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling: Updates to troubleshooting #3329

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

christos68k
Copy link
Member

Summary

  1. Replaced references to APM server with 'Collector'
  2. Added troubleshooting for newer HA connecting to older cluster

@christos68k christos68k requested a review from a team as a code owner November 1, 2023 20:05
@christos68k christos68k self-assigned this Nov 1, 2023
Copy link
Contributor

github-actions bot commented Nov 1, 2023

A documentation preview will be available soon:

Copy link
Contributor

mergify bot commented Nov 1, 2023

This pull request does not have a backport label. Could you fix it @christos68k? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@christos68k christos68k added backport-skip Skip notification from the automated backport with mergify enhancement New feature or request Profiling v8.12.0 labels Nov 1, 2023
mdbirnstiehl
mdbirnstiehl previously approved these changes Nov 1, 2023
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of capitalization suggestions. Otherwise, LGTM.

docs/en/observability/profiling-troubleshooting.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/profiling-troubleshooting.asciidoc Outdated Show resolved Hide resolved
@bmorelli25
Copy link
Member

Before we merge this— @christos68k I haven't heard of APM Server being renamed to "Collector". Do you know where that decision came from?

@bmorelli25
Copy link
Member

Never mind, I found the internal issue. LGTM!

@christos68k
Copy link
Member Author

Never mind, I found the internal issue. LGTM!

To clarify, AFAIK the APM server has not been renamed. This PR reflects the fact that we started running the profiling collector as a standalone process inside the integration server. Previously, it was part of the APM server codebase and was running inside the APM server process.

@christos68k christos68k requested a review from iogbole November 3, 2023 18:40
@bmorelli25
Copy link
Member

To clarify, AFAIK the APM server has not been renamed. This PR reflects the fact that we started running the profiling collector as a standalone process inside the integration server. Previously, it was part of the APM server codebase and was running inside the APM server process.

Thanks. This is why I was confused initially—I thought the APM Server had been renamed, and I hadn't heard anything about that.

Copy link
Contributor

@iogbole iogbole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christos68k christos68k enabled auto-merge (squash) November 6, 2023 15:51
@christos68k
Copy link
Member Author

christos68k commented Nov 7, 2023

@bmorelli25 Feel free to merge this (or trigger a new check run), I can't re-trigger the checks.

@mdbirnstiehl
Copy link
Contributor

@elasticmachine, run elasticsearch-ci/docs

@christos68k christos68k merged commit cff6bdf into elastic:main Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement New feature or request Profiling v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants