-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiling: Updates to troubleshooting #3329
Profiling: Updates to troubleshooting #3329
Conversation
Collector runs standalone and is no longer part of APM server.
A documentation preview will be available soon: |
This pull request does not have a backport label. Could you fix it @christos68k? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of capitalization suggestions. Otherwise, LGTM.
Before we merge this— @christos68k I haven't heard of APM Server being renamed to "Collector". Do you know where that decision came from? |
Never mind, I found the internal issue. LGTM! |
To clarify, AFAIK the APM server has not been renamed. This PR reflects the fact that we started running the profiling collector as a standalone process inside the integration server. Previously, it was part of the APM server codebase and was running inside the APM server process. |
Co-authored-by: Mike Birnstiehl <[email protected]>
Thanks. This is why I was confused initially—I thought the APM Server had been renamed, and I hadn't heard anything about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bmorelli25 Feel free to merge this (or trigger a new check run), I can't re-trigger the checks. |
@elasticmachine, run elasticsearch-ci/docs |
Summary