Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Add info on "SLO Overview" panel for custom dashboards #3331

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

colleenmcginnis
Copy link
Contributor

Closes #3269

Adds information on adding an SLO Overview panel to a custom dashboard. I wasn't sure where this should live, but decided on adding it to the end of the doc outlining how to create an SLO. I looked at the Kibana docs, but it doesn't look like we list all available panels anywhere over there (unless I missed it).

cc @grabowskit @emma-raffenne

@colleenmcginnis colleenmcginnis added the backport-8.11 Automated backport with mergify label Nov 2, 2023
@colleenmcginnis colleenmcginnis self-assigned this Nov 2, 2023
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 2, 2023 20:57
Copy link
Contributor

github-actions bot commented Nov 2, 2023

A documentation preview will be available soon:

mdbirnstiehl
mdbirnstiehl previously approved these changes Nov 2, 2023
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mgiota
Copy link
Contributor

mgiota commented Nov 7, 2023

@colleenmcginnis LGTM! I have only one concern. I am currently working on a bug to hide the SLO Overview embeddable for users without proper license (it should be platinum and above). So I am wondering if we should backport the documentation to 8.11 or better postpone it for 8.12 with one additional information that the SLO Overview Panel will be available to users with Platinum license and higher. What do you think?

@bmorelli25
Copy link
Member

So I am wondering if we should backport the documentation to 8.11 or better postpone it for 8.12 with one additional information that the SLO Overview Panel will be available to users with Platinum license and higher. What do you think?

I'd vote to remove the backport label on this PR and only add the docs to 8.12. We can add a link to the subscriptions page too—something similar to what we have in grant-cases-access.asciidoc:

To access and send cases to external systems, you need the {subscriptions}[appropriate license],

@colleenmcginnis colleenmcginnis added backport-skip Skip notification from the automated backport with mergify and removed backport-8.11 Automated backport with mergify labels Nov 8, 2023
After you've created your SLO, you can monitor it from the _SLOs_ page in Observability,
but you can also add an _SLO Overview_ panel to a custom dashboard.
After you've created your SLO, you can monitor it from the _SLOs_ page in Observability. If you have
the {subscriptions}[appropriate license], you can also add an _SLO Overview_ panel to a custom dashboard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like this wording as it ensures the subscriptions page remains the source of truth for the type of license that is needed.

bmorelli25
bmorelli25 previously approved these changes Nov 8, 2023
mgiota
mgiota previously approved these changes Nov 8, 2023
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colleenmcginnis colleenmcginnis dismissed stale reviews from mgiota and bmorelli25 via 8b12534 November 8, 2023 23:25
Comment on lines +11 to +14
[IMPORTANT]
====
To create and manage SLOs, you need an {subscriptions}[appropriate license] and <<slo-privileges,SLO access>> must be configured.
====
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grabowskit confirmed that SLO access is limited to Platinum/Enterprise/Trial users so I added a note to the top of all pages that cover SLOs:

To create and manage SLOs, you need an appropriate license and SLO access must be configured.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to this approach, but this would be a new pattern that, AFAIK, we don't replicate elsewhere in the docs. If we move forward with adding a banner to the top of every SLO page because the feature requires an elevated license, we should consider doing the same for other features in Obs that have the same requirement. For example:

Screenshot 2023-11-08 at 3 35 50 PM

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the change. I added a discussion point to our weekly agenda.

@colleenmcginnis colleenmcginnis merged commit 3527582 into elastic:main Nov 9, 2023
3 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-3269 branch November 9, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO]: Document SLO Overview Embeddable widget
4 participants