-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiling: introduce self-managed beta for 8.12 #3379
Conversation
A documentation preview will be available soon: |
This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
|
0f4b164
to
dfec1fa
Compare
dfec1fa
to
4b4c6e0
Compare
💚 Build Succeeded
History
cc @inge4pres |
4b4c6e0
to
f26667d
Compare
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
Signed-off-by: inge4pres <[email protected]>
f26667d
to
7d7816d
Compare
Signed-off-by: inge4pres <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes just for consistency and wording, and I think I have the document organization in a good place now, but please take a look and let me know if you have any questions or issues.
Signed-off-by: inge4pres <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Last review from me!
[[profiling-self-managed-supported-platforms]] | ||
== Prerequisites | ||
|
||
IMPORTANT: Running Universal Profiling on self hosted infrastructure requires an Elastic **Enterprise license**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this reflected on https://www.elastic.co/subscriptions? For legal reasons, we don't name the license level required in the documentation and instead link to the source of truth (the subscriptions page). Here's an example from the SLO docs:
To create and manage SLOs, you need an {subscriptions}[appropriate license].
Can we do the same here? Will UP be added to the subscriptions page when 8.12 releaes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I summon @iogbole on this one as I have no clue about the other page.
I am only aware that for on-prem we need Enterprise... we have a check in the code to enforce that.
@bmorelli25 can suggest what should be the appropriate format here?
I guess
IMPORTANT: Running Universal Profiling on self hosted infrastructure requires an Elastic **Enterprise license**. | |
IMPORTANT: Running Universal Profiling on self hosted infrastructure requires an Elastic **{subscriptions}[Enterprise license]**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved this line to the top of the page here to be consistent with the rest of the obs docs.
If we are able to get the Profiling subscription info on the subscriptions page, we wouldn't want to explicitly say what kind of license users need in the docs. With this in mind, I phrased it this way:
IMPORTANT: To run Universal Profiling on self-hosted Elastic stack, you need an {subscriptions}[appropriate license].
If we aren't able to get the info on the subscriptions page, maybe we can rephrase to be specific in this instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this now, I'll make a note to come back and check on the subscription statement when we get closer to the 8.13 release.
Reason for this PR
Addresses elastic/prodfiler/issues/4139.
Details
To be refined
The operational and troubleshooting sections are still empty, working on it in the next days