-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apm] Update content related to mobile APM agents for GA #3507
Conversation
A documentation preview will be available soon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryce-b Some questions for you below.
@@ -1,3 +1,79 @@ | |||
// tag::android[] | |||
*Add the agent to your project* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By version 1.0
this process will most likely change a lot, so I'm a bit concerned about duplicating it here and possibly forgetting to update it later 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmorelli25 do you think we should remove this until 1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair point, but process changes are inevitable, and I would hate not to have an Android tab on this page.
Is there a 1.0 release issue that we can add a task to so we don't forget to update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vote is to move forward with this content as-is and either open an issue or add to an issue to help us not forget to update this content as it changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was OOO, but it sounds good 👍 I created this issue which, when merged, will make this info no longer accurate.
* first pass at cleaning up apm agent mobile content * address feedback * clean up (cherry picked from commit 5853e1e)
* first pass at cleaning up apm agent mobile content * address feedback * clean up (cherry picked from commit 5853e1e) Co-authored-by: Colleen McGinnis <[email protected]>
Closes #3377
I updated the quickstart/installation instructions as requested in #3377:
I also did a broad search for
iOS
andAndroid
to check other references to the mobile APM agents resulting to the following additional updates:traces-apm.rum-<namespace>
also apply to Android in APM data streams?