Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apm] Update content related to mobile APM agents for GA #3507

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Jan 4, 2024

Closes #3377

I updated the quickstart/installation instructions as requested in #3377:

I also did a broad search for iOS and Android to check other references to the mobile APM agents resulting to the following additional updates:

@colleenmcginnis colleenmcginnis self-assigned this Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

A documentation preview will be available soon:

@colleenmcginnis colleenmcginnis added the backport-8.12 Automated backport with mergify label Jan 4, 2024
bryce-b
bryce-b previously approved these changes Jan 5, 2024
Copy link
Contributor Author

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryce-b Some questions for you below.

docs/en/observability/apm/data-model.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/apm/data-streams.asciidoc Outdated Show resolved Hide resolved
@colleenmcginnis colleenmcginnis marked this pull request as ready for review January 10, 2024 17:33
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner January 10, 2024 17:33
@@ -1,3 +1,79 @@
// tag::android[]
*Add the agent to your project*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By version 1.0 this process will most likely change a lot, so I'm a bit concerned about duplicating it here and possibly forgetting to update it later 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 do you think we should remove this until 1.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair point, but process changes are inevitable, and I would hate not to have an Android tab on this page.

Is there a 1.0 release issue that we can add a task to so we don't forget to update this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vote is to move forward with this content as-is and either open an issue or add to an issue to help us not forget to update this content as it changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was OOO, but it sounds good 👍 I created this issue which, when merged, will make this info no longer accurate.

@colleenmcginnis colleenmcginnis merged commit 5853e1e into elastic:main Jan 12, 2024
7 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-3377 branch January 12, 2024 19:10
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
* first pass at cleaning up apm agent mobile content

* address feedback

* clean up

(cherry picked from commit 5853e1e)
colleenmcginnis added a commit that referenced this pull request Jan 12, 2024
* first pass at cleaning up apm agent mobile content

* address feedback

* clean up

(cherry picked from commit 5853e1e)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Mobile Docs for GA
4 participants