Remove outdated log correlation docs #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon: |
|
I don't really know about |
This comment was marked as outdated.
This comment was marked as outdated.
lucabelluccini
approved these changes
Feb 9, 2024
mdbirnstiehl
approved these changes
Feb 12, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
* remove outdated log correlation docs * timestamp req’d * fix broken link (cherry picked from commit 10bdaa9)
bmorelli25
added a commit
that referenced
this pull request
Feb 12, 2024
* remove outdated log correlation docs * timestamp req’d * fix broken link (cherry picked from commit 10bdaa9) Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #3356, @mdbirnstiehl rewrote our application logs documentation. The old page, however, still exists.
This PR removes the old page and points to the new Stream Application Logs page.
Related issue
@lucabelluccini requested two enhancements to our log correlation docs in elastic/apm-server#11243:
@timestampandevent.dataset(preferred).I believe Mike's PR addressed point one. I've updated our new content to include
@timestampas required (cc @mdbirnstiehl). I also believe our new docs do a much better job of linking out to the ECS docs for more ino.Closes elastic/apm-server#11243.
Remaining questions
@lucabelluccini can you explain this a little more? @mdbirnstiehl, do you know what this refers to?
To do