Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename doc-preview.yml to docs-preview.yml #3601

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

bmorelli25
Copy link
Member

Move away from our own custom implementation of commenting on PRs to the shared implementation.

@bmorelli25 bmorelli25 marked this pull request as ready for review February 8, 2024 16:41
@bmorelli25 bmorelli25 requested a review from a team as a code owner February 8, 2024 16:41
Copy link
Contributor

mergify bot commented Feb 8, 2024

This pull request does not have a backport label. Could you fix it @bmorelli25? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 8, 2024
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@bmorelli25
Copy link
Member Author

bump bump

@bmorelli25
Copy link
Member Author

oh wow just needed to refresh

@bmorelli25 bmorelli25 merged commit f3daba8 into main Feb 9, 2024
7 checks passed
@bmorelli25 bmorelli25 deleted the bmorelli25-patch-3 branch February 9, 2024 19:36
@bmorelli25 bmorelli25 added backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.1 Automated backport with mergify backport-8.2 Automated backport with mergify backport-8.0 Automated backport with mergify backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify backport-8.8 Automated backport with mergify backport-8.3 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Apr 15, 2024
@bmorelli25
Copy link
Member Author

Backports are failing because this check wasn't backported to old versions. I'm just gonna take it back.

mergify bot pushed a commit that referenced this pull request Apr 15, 2024
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

# Conflicts:
#	.github/workflows/doc-preview.yml
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

# Conflicts:
#	.github/workflows/doc-preview.yml
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

# Conflicts:
#	.github/workflows/doc-preview.yml
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

# Conflicts:
#	.github/workflows/doc-preview.yml

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

# Conflicts:
#	.github/workflows/doc-preview.yml

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

# Conflicts:
#	.github/workflows/doc-preview.yml

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit f3daba8)

Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.0 Automated backport with mergify backport-8.1 Automated backport with mergify backport-8.2 Automated backport with mergify backport-8.3 Automated backport with mergify backport-8.4 Automated backport with mergify backport-8.5 Automated backport with mergify backport-8.6 Automated backport with mergify backport-8.7 Automated backport with mergify backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants