Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about timeslice SLI #3604

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Feb 9, 2024

Closes #3580 for stateful docs.

Also updates "Partition by" to "Group by" to match the 8.12 UI.

A couple of thoughts:

  • I think we can improve the formatting on this page, but I didn't have time to wrestle with that during this sprint.
  • The examples would probably be clearer with screen captures, but the topic is already pretty long. If we plan to add a bunch more indicators, we might want to reconsider how this topic is structured (everything on one page) and consider breaking it down into multiple topics.

@dedemorton dedemorton self-assigned this Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

A documentation preview will be available soon:

Copy link
Contributor

mergify bot commented Feb 9, 2024

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 9, 2024
@dedemorton dedemorton added backport-8.12 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Feb 12, 2024
@dedemorton
Copy link
Contributor Author

dedemorton commented Feb 14, 2024

TODO: Use example suggested by Francismara S:

"Here's one timeslice example i could think of. In this scenario, i'm creating an SLO for a Kubernetes Statefulset, i'm retrieving the last values of both kubernetes.statefulset.replicas.ready and kubernetes.statefulset.replicas.observed. Then, I'm using the equation A == B ? 1 : 0, where A represents the number of ready replicas and B represents the number of observed replicas. This equation returns 1 if the condition A == B is true (indicating the same number of replicas) and 0 otherwise. The condition is when this equation evaluates to a value less than 1."

image

Screenshot 2024-02-14 at 13.37.31.png

@dedemorton dedemorton force-pushed the issue#3580 branch 2 times, most recently from 03504c6 to e9d7b21 Compare February 16, 2024 00:36
@dedemorton dedemorton marked this pull request as ready for review February 16, 2024 00:39
@dedemorton dedemorton requested a review from a team as a code owner February 16, 2024 00:39
@dedemorton dedemorton added the backport-8.13 Automated backport with mergify label Feb 16, 2024
@dedemorton dedemorton merged commit 2311c5e into elastic:main Feb 20, 2024
7 checks passed
@dedemorton dedemorton deleted the issue#3580 branch February 20, 2024 22:45
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
dedemorton added a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit 2311c5e)

Co-authored-by: DeDe Morton <[email protected]>
dedemorton added a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit 2311c5e)

Co-authored-by: DeDe Morton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Document new Timeslice Metric indicator for SLOs
3 participants