Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alerting navigation more consistent with serverless docs #3640

Merged
merged 5 commits into from
Feb 24, 2024

Conversation

dedemorton
Copy link
Contributor

Closes #3639

Changes are mostly structural/organizational to make the navigation easier to scan and more consistent with the serverless docs. Note that the full topic titles still appear on the page to add context for SEO, but the short title is used in the navigation for easier scanning.

More changes are coming to the content later....

@mdbirnstiehl I've changed "Logs threshold rule" > "Log threshold rule" to match the UI. When we refer to the rule, I think we should use text that matches the UI. If the text in the UI isn't right, we should change it in the UI then update the docs. WDYT?

Before

image

After

image

@dedemorton dedemorton added backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify labels Feb 23, 2024
@dedemorton dedemorton self-assigned this Feb 23, 2024
@dedemorton dedemorton requested a review from a team as a code owner February 23, 2024 19:54
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

mdbirnstiehl
mdbirnstiehl previously approved these changes Feb 23, 2024
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question otherwise LGTM!

docs/en/observability/metrics-threshold-alert.asciidoc Outdated Show resolved Hide resolved
@dedemorton dedemorton merged commit e64842f into elastic:main Feb 24, 2024
3 checks passed
@dedemorton dedemorton deleted the issue#3639 branch February 24, 2024 00:18
mergify bot pushed a commit that referenced this pull request Feb 24, 2024
mergify bot pushed a commit that referenced this pull request Feb 24, 2024
dedemorton added a commit that referenced this pull request Feb 24, 2024
dedemorton added a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make alerting navigation consistent with serverless
2 participants