Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to workaround about using custom CAs in private locations #3834

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Apr 26, 2024

Closes #3833.

Someone who is an SME should make sure this note is accurate and in the right place. Synthetics is not my area of expertise; I'm just trying to help out.

IMO pointing to that GitHub issue may not be the best approach because the details in the issue seem speculative. It would be much better if we could be proscriptive and tell users exactly how to work around the problem. That is beyond of the scope of what was requested in #3833 and would need some effort from folks outside of the docs team.

TODO (after merging):

@dedemorton dedemorton self-assigned this Apr 26, 2024
@dedemorton dedemorton requested a review from a team as a code owner April 26, 2024 22:39
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Apr 26, 2024

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 26, 2024
@dedemorton dedemorton added backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify labels Apr 26, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Apr 26, 2024
@vigneshshanmugam vigneshshanmugam self-requested a review April 29, 2024 17:02
@vigneshshanmugam
Copy link
Member

Thank you @dedemorton for the help.

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dedemorton dedemorton merged commit 09798bb into elastic:main Apr 30, 2024
3 checks passed
@dedemorton dedemorton deleted the issue#3833 branch April 30, 2024 17:44
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
…3834)

* Add link to workaround about using custom CAs in private locations

* Update docs/en/observability/synthetics-private-location.asciidoc

Co-authored-by: Vignesh Shanmugam <[email protected]>

---------

Co-authored-by: Vignesh Shanmugam <[email protected]>
(cherry picked from commit 09798bb)
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
…3834)

* Add link to workaround about using custom CAs in private locations

* Update docs/en/observability/synthetics-private-location.asciidoc

Co-authored-by: Vignesh Shanmugam <[email protected]>

---------

Co-authored-by: Vignesh Shanmugam <[email protected]>
(cherry picked from commit 09798bb)
@dedemorton
Copy link
Contributor Author

@vigneshshanmugam Before I make this change in the serverless docs, can you confirm that it is needed there? Thanks!

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented Apr 30, 2024

@dedemorton Yes, it does apply to private locations in Serverless as well.

bmorelli25 pushed a commit that referenced this pull request May 1, 2024
…3834) (#3842)

* Add link to workaround about using custom CAs in private locations

* Update docs/en/observability/synthetics-private-location.asciidoc

Co-authored-by: Vignesh Shanmugam <[email protected]>

---------

Co-authored-by: Vignesh Shanmugam <[email protected]>
(cherry picked from commit 09798bb)

Co-authored-by: DeDe Morton <[email protected]>
bmorelli25 pushed a commit that referenced this pull request May 1, 2024
…3834) (#3841)

* Add link to workaround about using custom CAs in private locations

* Update docs/en/observability/synthetics-private-location.asciidoc

Co-authored-by: Vignesh Shanmugam <[email protected]>

---------

Co-authored-by: Vignesh Shanmugam <[email protected]>
(cherry picked from commit 09798bb)

Co-authored-by: DeDe Morton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning in docs that custom CAs don't work in private locations
3 participants