Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add set_es_document_id parameter in doc and fix es_datastream_name #3914

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to add documentation for the new config parameter added in this PR: https://github.com/elastic/cloud/pull/126020
This PR should be merged after ms-108 public release.

Also I see es_datastream_name documentation is outdated after this PR got merged.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner May 20, 2024 21:47
@kaiyan-sheng kaiyan-sheng self-assigned this May 20, 2024
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented May 20, 2024

This pull request does not have a backport label. Could you fix it @kaiyan-sheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 20, 2024
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed a small change.

I'm monitoring the ms-108 release. It looks like we'll be able to merge this either later today or on Monday.

@bmorelli25 bmorelli25 enabled auto-merge (squash) June 4, 2024 21:18
@bmorelli25
Copy link
Member

ms-108 is live

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@bmorelli25 bmorelli25 merged commit dc68564 into elastic:main Jun 4, 2024
3 checks passed
@bmorelli25 bmorelli25 added backport-8.14 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jun 4, 2024
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
…3914)

* add set_es_document_id parameter in doc and fix es_datastream_name

* Update monitor-aws-firehose.asciidoc

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit dc68564)
bmorelli25 pushed a commit that referenced this pull request Jun 5, 2024
…3914) (#3967)

* add set_es_document_id parameter in doc and fix es_datastream_name

* Update monitor-aws-firehose.asciidoc

---------

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit dc68564)

Co-authored-by: kaiyan-sheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants