Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics support for firehose into documentation #4046

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to add documentation for the new feature we added for ingesting metrics using Firehose.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner July 3, 2024 00:10
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request does not have a backport label. Could you fix it @kaiyan-sheng? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 3, 2024
alaudazzi
alaudazzi previously approved these changes Jul 3, 2024
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few minor editing suggestions, otherwise LGTM.

@alaudazzi alaudazzi added backport-8.14 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jul 3, 2024
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaudazzi alaudazzi merged commit 0e4e68b into elastic:main Jul 9, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jul 9, 2024
* Add metrics support for firehose into documentation

* Update docs/en/observability/cloud-monitoring/aws/monitor-aws-firehose.asciidoc

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit 0e4e68b)
@kaiyan-sheng kaiyan-sheng deleted the firehose_metrics branch July 9, 2024 14:11
kaiyan-sheng added a commit that referenced this pull request Jul 9, 2024
* Add metrics support for firehose into documentation

* Update docs/en/observability/cloud-monitoring/aws/monitor-aws-firehose.asciidoc

Co-authored-by: Arianna Laudazzi <[email protected]>

---------

Co-authored-by: Arianna Laudazzi <[email protected]>
(cherry picked from commit 0e4e68b)

Co-authored-by: kaiyan-sheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants