Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/otel-direct: fix code snippet rendering in table #4095

Merged
merged 2 commits into from
Jul 26, 2024
Merged

docs/otel-direct: fix code snippet rendering in table #4095

merged 2 commits into from
Jul 26, 2024

Conversation

xrmx
Copy link
Member

@xrmx xrmx commented Jul 25, 2024 •
edited
Loading

Fixes #4092

@xrmx xrmx requested a review from a team as a code owner July 25, 2024 09:06
@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@xrmx xrmx marked this pull request as draft July 25, 2024 09:06
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 25, 2024

This pull request does not have a backport label. Could you fix it @xrmx? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 25, 2024
@xrmx xrmx mentioned this pull request Jul 25, 2024
Merged
@xrmx xrmx force-pushed the xrmx-fix-otel-direct-rendering branch from c4dd378 to 9057ea8 Compare July 25, 2024 09:27
@xrmx xrmx marked this pull request as ready for review July 25, 2024 09:28
colleenmcginnis
colleenmcginnis approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good ✨

@xrmx xrmx merged commit 8e5c9cd into main Jul 26, 2024
3 checks passed
@xrmx xrmx deleted the xrmx-fix-otel-direct-rendering branch July 26, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrmx @colleenmcginnis