Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port EEM and new services experience docs to stateful #4113

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Port EEM and new services experience docs to stateful #4113

merged 9 commits into from
Aug 8, 2024

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Aug 3, 2024 •
edited
Loading

Ports #4062 to stateful. Also makes some minor tweaks to serverless docs to mirror structural changes needed for stateful docs.

Previews:

TODO:

@dedemorton dedemorton self-assigned this Aug 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 3, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 3, 2024

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Aug 3, 2024
@dedemorton dedemorton added the backport-8.15 Automated backport with mergify label Aug 5, 2024
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Aug 5, 2024
@dedemorton dedemorton marked this pull request as ready for review August 6, 2024 18:46
@dedemorton dedemorton requested a review from a team as a code owner August 6, 2024 18:46
@dedemorton
Copy link
Contributor Author

@klacabane Can you check the privileges for enabling/disabling the EEM to make sure they are correct for "stateful"?

@dedemorton dedemorton requested a review from klacabane August 7, 2024 17:23
@dedemorton
Copy link
Contributor Author

@klacabane I've applied your changes, and this PR should be ready for final approval (assuming the doc builds pass). Thanks for your input!

@elasticdocs
Copy link

elasticdocs commented Aug 7, 2024 •
edited
Loading

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

mdbirnstiehl
mdbirnstiehl reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise LGTM!

docs/en/observability/elastic-entity-model.asciidoc Outdated Show resolved Hide resolved
mdbirnstiehl
mdbirnstiehl approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dedemorton
Copy link
Contributor Author

I'm going to merge this. If there are any additional changes required, I can follow up with another PR. Thanks everyone!

@dedemorton dedemorton merged commit 618cc64 into elastic:main Aug 8, 2024
4 checks passed
@dedemorton dedemorton deleted the port#4062_stateful branch August 8, 2024 17:36
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@dedemorton @mergify
Port EEM and new services experience docs to stateful (#4113)
217697d 
---------

Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit 618cc64)

# Conflicts:
#	docs/en/serverless/elastic-entity-model.mdx
@mergify mergify bot mentioned this pull request Aug 8, 2024
Merged
3 tasks
dedemorton added a commit that referenced this pull request Aug 8, 2024
@mergify @dedemorton @github-actions
[8.15](backport #4113) Port EEM and new services experience docs to s…
6fd1742 
…tateful (#4132)

* Port EEM and new services experience docs to stateful (#4113)

---------

Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit 618cc64)

* Delete docs/en/serverless directory

---------

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dedemorton added a commit that referenced this pull request Sep 10, 2024
@dedemorton
Revert "[8.15](backport #4113) Port EEM and new services experience d…
9849788 
…ocs to s…"

This reverts commit 6fd1742.
dedemorton added a commit that referenced this pull request Sep 11, 2024
@dedemorton
Revert "[8.15](backport #4113) Port EEM and new services experience d…
c11f787 
…ocs to s…" (#4236)

This reverts commit 6fd1742.
This was referenced Oct 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

@klacabane klacabane Awaiting requested review from klacabane

Assignees

@dedemorton dedemorton

Labels
backport-8.15 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dedemorton @elasticdocs @klacabane @mdbirnstiehl