-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O11y AI Assistant - Google Gemini support #4143
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
@lucabelluccini There's one more place where we mention supported connectors. Do you want me to take over this PR and make the required changes? |
Hello @dedemorton - if you can, it would be ideal. |
We would like to specify supported versions within the model (i.e., the Gemini model in this case). Checking with @emma-raffenne and team on the min supported version etc. |
@lucabelluccini and @dedemorton We have tested the following versions, using simulated function calling for both:
Given we haven't tested the |
This should be ready for final review as soon as the build passes. |
Hello! Just FYI, our own docs (linked above) sets Thank you all for the help! |
Good point. My change contradicts itself. 😸 @emma-raffenne Let me know what I should say. |
@dedemorton @lucabelluccini I thinks we need to make a couple of changes:
Additionally we could add the list of the models we have tested with but I would need to confirm the full list. Let's not include them here for now. Would that work? |
@emma-raffenne Is this change what you had in mind, or do you still want me to list supported versions, but point to the connector docs for defaults? (I am using a generic link to the connector docs because we already show links elsewhere.) IMO it would be great if the connector docs were a single source of truth wrt what is supported and what the defaults are, but right now, those docs don't contain all those details. And I'm not sure if our AI Assistant has special requirements that apply only to the Obs AI Assistant. Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton Thank you for the changes. LGTM.
I 100% agree that the Connectors docs should be the single source of truth.
AFAIK, so far there are no specific requirements for the Obs AI Assistant.
As the AI Connector of Platform can be used by both O11y & Security, we should try to converge what's common in the connectors docs and recommendations for O11y in the O11y AI docs, notably:
|
@lucabelluccini Please accept my apologies for taking so long to get this merged. I've been working on a totally different project. In the interest of getting this merged, I'm going to merge this PR now and create a follow-up issue to address the concerns you expressed in your comment. (I think more discussion might be required to figure out the right way to document the recommendations.) |
Closes #4087. |
* AI Assistant Gemini AI * Add google gemini details * Specify supported models of Gemini * Apply changes from review --------- Co-authored-by: dedemorton <[email protected]> (cherry picked from commit 4143855) # Conflicts: # docs/en/observability/observability-ai-assistant.asciidoc
* AI Assistant Gemini AI * Add google gemini details * Specify supported models of Gemini * Apply changes from review --------- Co-authored-by: dedemorton <[email protected]> (cherry picked from commit 4143855) # Conflicts: # docs/en/observability/observability-ai-assistant.asciidoc
* AI Assistant Gemini AI * Add google gemini details * Specify supported models of Gemini * Apply changes from review --------- Co-authored-by: dedemorton <[email protected]> (cherry picked from commit 4143855)
* O11y AI Assistant - Google Gemini support (#4143) * AI Assistant Gemini AI * Add google gemini details * Specify supported models of Gemini * Apply changes from review --------- Co-authored-by: dedemorton <[email protected]> (cherry picked from commit 4143855) * fix typo --------- Co-authored-by: Luca Belluccini <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
* O11y AI Assistant - Google Gemini support (#4143) * AI Assistant Gemini AI * Add google gemini details * Specify supported models of Gemini * Apply changes from review --------- Co-authored-by: dedemorton <[email protected]> (cherry picked from commit 4143855) # Conflicts: # docs/en/observability/observability-ai-assistant.asciidoc * Fix typo * Update observability-ai-assistant.asciidoc --------- Co-authored-by: Luca Belluccini <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Brandon Morelli <[email protected]>
* O11y AI Assistant - Google Gemini support (#4143) * AI Assistant Gemini AI * Add google gemini details * Specify supported models of Gemini * Apply changes from review --------- Co-authored-by: dedemorton <[email protected]> (cherry picked from commit 4143855) # Conflicts: # docs/en/observability/observability-ai-assistant.asciidoc * Fix typo * fix conflicts --------- Co-authored-by: Luca Belluccini <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Brandon Morelli <[email protected]>
We document Google Gemini in the connectors https://www.elastic.co/guide/en/kibana/current/gemini-action-type.html and in our release highlights https://www.elastic.co/guide/en/observability/current/whats-new.html, but it's missing from the o11y docs.
Add this mention to any place we list the supported connectors with the O11y AI Assistant.
TODO after merging: