Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O11y AI Assistant - Google Gemini support #4143

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Aug 12, 2024

We document Google Gemini in the connectors https://www.elastic.co/guide/en/kibana/current/gemini-action-type.html and in our release highlights https://www.elastic.co/guide/en/observability/current/whats-new.html, but it's missing from the o11y docs.

Add this mention to any place we list the supported connectors with the O11y AI Assistant.

TODO after merging:

@lucabelluccini lucabelluccini requested a review from a team as a code owner August 12, 2024 19:08
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@dedemorton
Copy link
Contributor

@lucabelluccini There's one more place where we mention supported connectors. Do you want me to take over this PR and make the required changes?

@lucabelluccini
Copy link
Contributor Author

Hello @dedemorton - if you can, it would be ideal.
In particular, I would suggest to check with @grabowskit to verify if we need to mention only specific models are compatible with O11y AI Assistant.

@dedemorton dedemorton self-assigned this Aug 13, 2024
@dedemorton dedemorton requested a review from grabowskit August 13, 2024 22:24
@dedemorton dedemorton added the backport-main Automated backport with mergify label Aug 13, 2024
@vinaychandrasekhar
Copy link

We would like to specify supported versions within the model (i.e., the Gemini model in this case).

Checking with @emma-raffenne and team on the min supported version etc.

@emma-raffenne
Copy link

@lucabelluccini and @dedemorton

We have tested the following versions, using simulated function calling for both:

  • gemini-1.5-pro-preview-0409
  • gemini-1.5-flash-001

Given we haven't tested the gemini-1.5-pro-001 version, I think it's better not to support it until we can confirm the results of its evaluation.

cc @vinaychandrasekhar

@dedemorton
Copy link
Contributor

This should be ready for final review as soon as the build passes.

@lucabelluccini
Copy link
Contributor Author

lucabelluccini commented Aug 20, 2024

Hello! Just FYI, our own docs (linked above) sets gemini-1.5-pro-001 as default - see here

Thank you all for the help!

@dedemorton
Copy link
Contributor

Just FYI, our own docs (linked above) sets gemini-1.5-pro-001

Good point. My change contradicts itself. 😸

@emma-raffenne Let me know what I should say.

@emma-raffenne
Copy link

@dedemorton @lucabelluccini
After reviewing this part:

Screenshot 2024-08-21 at 12 19 11

I thinks we need to make a couple of changes:

  • the observability AI assistant can use GenAI services that do not support function calling. In that case, the "Simulate function calling" setting needs to be enabled.
  • the obs AI Assistant supports OpenAI, Amazon Bedrock, and Google Gemini connectors. I would recommend to link to each connector page of the Kibana Stack Management docs to rely on what's indicated there as per default model. If the default model needs to be updated, it should be at the connector page.

Additionally we could add the list of the models we have tested with but I would need to confirm the full list. Let's not include them here for now.

Would that work?

@dedemorton
Copy link
Contributor

@emma-raffenne Is this change what you had in mind, or do you still want me to list supported versions, but point to the connector docs for defaults? (I am using a generic link to the connector docs because we already show links elsewhere.) IMO it would be great if the connector docs were a single source of truth wrt what is supported and what the defaults are, but right now, those docs don't contain all those details. And I'm not sure if our AI Assistant has special requirements that apply only to the Obs AI Assistant. Let me know what you think.

@dedemorton dedemorton requested review from emma-raffenne and removed request for grabowskit August 29, 2024 23:03
Copy link

@emma-raffenne emma-raffenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedemorton Thank you for the changes. LGTM.
I 100% agree that the Connectors docs should be the single source of truth.
AFAIK, so far there are no specific requirements for the Obs AI Assistant.

@lucabelluccini
Copy link
Contributor Author

As the AI Connector of Platform can be used by both O11y & Security, we should try to converge what's common in the connectors docs and recommendations for O11y in the O11y AI docs, notably:

  • we do not recommend BYO-LLM (Security seems to "allow" it)
  • you need a non-free tier or otherwise you'll hit rate limiting immediately - this might be applicable to all connectors(?)
  • function calling and switch to simulate function calling - this might be applicable to all connectors(?)
  • O11y might be tested only with specific 3rd party vendors and models and maybe in the future the platform offering will diverge vs O11y or Security specific recommendations

@bmorelli25 bmorelli25 added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@dedemorton dedemorton added the backport-8.16 Automated backport with mergify label Oct 18, 2024
@dedemorton
Copy link
Contributor

@lucabelluccini Please accept my apologies for taking so long to get this merged. I've been working on a totally different project. In the interest of getting this merged, I'm going to merge this PR now and create a follow-up issue to address the concerns you expressed in your comment. (I think more discussion might be required to figure out the right way to document the recommendations.)

@dedemorton
Copy link
Contributor

Closes #4087.

@dedemorton dedemorton merged commit 4143855 into 8.15 Oct 18, 2024
10 checks passed
@dedemorton dedemorton deleted the docs/google-gemini-ai branch October 18, 2024 21:53
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
* AI Assistant Gemini AI

* Add google gemini details

* Specify supported models of Gemini

* Apply changes from review

---------

Co-authored-by: dedemorton <[email protected]>
(cherry picked from commit 4143855)

# Conflicts:
#	docs/en/observability/observability-ai-assistant.asciidoc
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
* AI Assistant Gemini AI

* Add google gemini details

* Specify supported models of Gemini

* Apply changes from review

---------

Co-authored-by: dedemorton <[email protected]>
(cherry picked from commit 4143855)

# Conflicts:
#	docs/en/observability/observability-ai-assistant.asciidoc
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
* AI Assistant Gemini AI

* Add google gemini details

* Specify supported models of Gemini

* Apply changes from review

---------

Co-authored-by: dedemorton <[email protected]>
(cherry picked from commit 4143855)
dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Oct 18, 2024
@dedemorton dedemorton mentioned this pull request Oct 18, 2024
9 tasks
bmorelli25 pushed a commit that referenced this pull request Oct 18, 2024
* O11y AI Assistant -  Google Gemini support (#4143)

* AI Assistant Gemini AI

* Add google gemini details

* Specify supported models of Gemini

* Apply changes from review

---------

Co-authored-by: dedemorton <[email protected]>
(cherry picked from commit 4143855)

* fix typo

---------

Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
dedemorton added a commit that referenced this pull request Oct 18, 2024
bmorelli25 added a commit that referenced this pull request Oct 19, 2024
* O11y AI Assistant -  Google Gemini support (#4143)

* AI Assistant Gemini AI

* Add google gemini details

* Specify supported models of Gemini

* Apply changes from review

---------

Co-authored-by: dedemorton <[email protected]>
(cherry picked from commit 4143855)

# Conflicts:
#	docs/en/observability/observability-ai-assistant.asciidoc

* Fix typo

* Update observability-ai-assistant.asciidoc

---------

Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Oct 19, 2024
* O11y AI Assistant -  Google Gemini support (#4143)

* AI Assistant Gemini AI

* Add google gemini details

* Specify supported models of Gemini

* Apply changes from review

---------

Co-authored-by: dedemorton <[email protected]>
(cherry picked from commit 4143855)

# Conflicts:
#	docs/en/observability/observability-ai-assistant.asciidoc

* Fix typo

* fix conflicts

---------

Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-main Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants