Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to prefer-ilm setting for apm lifeycle known bug #4501

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

lahsivjar
Copy link
Contributor

Description

Clarify that one of the suggested fix for the unmanaged indices bug introduced in 8.15.0 and fixed in 8.15.1 should only be applied for datatreams with default policies (as they are the only ones affected). If the suggested fix was applied to a datastream using custom ILM policy then the prefer_ilm setting needs to be added to the custom ILM policy.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@lahsivjar lahsivjar added backport-8.15 Automated backport with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 8, 2024
@lahsivjar lahsivjar requested a review from a team as a code owner November 8, 2024 13:17
@lahsivjar lahsivjar requested review from simitt and endorama November 8, 2024 13:17
Copy link
Contributor

github-actions bot commented Nov 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

which should be equivalent to the default ILM policies. Note that if you have a custom
lifecycle policy in place for any of the datastreams then you don't need to do anything
for those datastreams as they are not affected by this bug. Going forward, for using
custom ILM policies with new datastreams, please consult the {ref}/apm-ilm-how-to.html[updated guide].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think this belongs here? If I have a custom ILM policy I don't even read this line due to

The issue also does not occur if a custom ILM policy is configured using a custom component template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a stab at updating this in a different way to avoid confusion. PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks good to me now - are you planning on also adding the prefer-ilm section to this PR or a separate one? (The PR description is not updated)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25
Copy link
Member

Added two commits from an open PR (#4506) that also makes updates to this file.

@bmorelli25
Copy link
Member

I made a few small changes to the text. Please take a look and let me know if this still looks okay. If so, we'll get this merged. Thanks!

@lahsivjar
Copy link
Contributor Author

Thanks @bmorelli25 , a minor comment - rest LGTM!

@bmorelli25 bmorelli25 enabled auto-merge (squash) November 8, 2024 19:11
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@bmorelli25 bmorelli25 merged commit c576b14 into elastic:main Nov 8, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
* Add reference to prefer-ilm setting for apm lifeycle known bug

* Refactor

* APM known issue correction

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* clean up text

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Vishal Raj <[email protected]>

---------

Co-authored-by: Francesco Gualazzi <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c576b14)
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
* Add reference to prefer-ilm setting for apm lifeycle known bug

* Refactor

* APM known issue correction

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* clean up text

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Vishal Raj <[email protected]>

---------

Co-authored-by: Francesco Gualazzi <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c576b14)
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
* Add reference to prefer-ilm setting for apm lifeycle known bug

* Refactor

* APM known issue correction

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* clean up text

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Vishal Raj <[email protected]>

---------

Co-authored-by: Francesco Gualazzi <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c576b14)
bmorelli25 pushed a commit that referenced this pull request Nov 8, 2024
#4515)

* Add reference to prefer-ilm setting for apm lifeycle known bug

* Refactor

* APM known issue correction

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* clean up text

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Vishal Raj <[email protected]>

---------

Co-authored-by: Francesco Gualazzi <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c576b14)

Co-authored-by: Vishal Raj <[email protected]>
bmorelli25 pushed a commit that referenced this pull request Nov 8, 2024
#4514)

* Add reference to prefer-ilm setting for apm lifeycle known bug

* Refactor

* APM known issue correction

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* clean up text

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Vishal Raj <[email protected]>

---------

Co-authored-by: Francesco Gualazzi <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c576b14)

Co-authored-by: Vishal Raj <[email protected]>
bmorelli25 pushed a commit that referenced this pull request Nov 8, 2024
#4516)

* Add reference to prefer-ilm setting for apm lifeycle known bug

* Refactor

* APM known issue correction

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

* clean up text

* Update docs/en/observability/apm/known-issues.asciidoc

Co-authored-by: Vishal Raj <[email protected]>

---------

Co-authored-by: Francesco Gualazzi <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit c576b14)

Co-authored-by: Vishal Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport with mergify backport-8.16 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants