Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to serverless docs from main obs guide #4546

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Nov 19, 2024

Description

Adds link to serverless docs from main page of stateful docs.

image

Questions:

  • Should I add a card to the related documentation section instead? Or maybe provide the link in the intro and add a card?

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4248

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@dedemorton dedemorton added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 19, 2024
@dedemorton dedemorton requested a review from a team as a code owner November 19, 2024 02:06
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is sufficient. Should we add a similar link to the Observability section of the serverless docs that links to the stateful docs?

@dedemorton
Copy link
Contributor Author

Should we add a similar link to the Observability section of the serverless docs that links to the stateful docs?

Yes, that makes sense!

@dedemorton dedemorton enabled auto-merge (squash) November 21, 2024 18:18
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedemorton dedemorton merged commit cbc468c into elastic:main Nov 22, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
* Link to serverless docs from main obs guide

* Tweak wording

* Add link from serverless to stateful docs

(cherry picked from commit cbc468c)

# Conflicts:
#	docs/en/serverless/what-is-observability-serverless.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
* Link to serverless docs from main obs guide

* Tweak wording

* Add link from serverless to stateful docs

(cherry picked from commit cbc468c)

# Conflicts:
#	docs/en/serverless/what-is-observability-serverless.asciidoc
@colleenmcginnis colleenmcginnis added the backport-8.17 Automated backport with mergify label Nov 22, 2024
mergify bot pushed a commit that referenced this pull request Nov 22, 2024
* Link to serverless docs from main obs guide

* Tweak wording

* Add link from serverless to stateful docs

(cherry picked from commit cbc468c)

# Conflicts:
#	docs/en/serverless/what-is-observability-serverless.asciidoc
dedemorton added a commit that referenced this pull request Nov 22, 2024
)

* Link to serverless docs from main obs guide (#4546)

* Link to serverless docs from main obs guide

* Tweak wording

* Add link from serverless to stateful docs

(cherry picked from commit cbc468c)

---------

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dedemorton added a commit that referenced this pull request Nov 22, 2024
…4570)

* Link to serverless docs from main obs guide (#4546)

* Link to serverless docs from main obs guide

* Tweak wording

* Add link from serverless to stateful docs

(cherry picked from commit cbc468c)

---------

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dedemorton added a commit that referenced this pull request Nov 22, 2024
…4573)

* Link to serverless docs from main obs guide (#4546)

* Link to serverless docs from main obs guide

* Tweak wording

* Add link from serverless to stateful docs

(cherry picked from commit cbc468c)


---------

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Observability landing page
2 participants