-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apm] Apply APM IA changes to serverless docs #4593
[apm] Apply APM IA changes to serverless docs #4593
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request is now in conflict. Could you fix it @colleenmcginnis? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these IA changes are a big improvement. Nice work! I just had a couple of comments about stuff that you can defer, if you want, because it's not related to the IA changes.
Here are a few notes about stuff you probably already know about (just including the info here for the sake of completeness).
These topics exist in stateful, but not serverless (probably aren't supported and/or weren't in the original serverless docs):
- https://www.elastic.co/guide/en/observability/current/apm-mobile-service-overview.html
- https://www.elastic.co/guide/en/observability/current/apm-mobile-session-explorer.html
- https://www.elastic.co/guide/en/observability/current/apm-agent-explorer.html
This topic uses short title in stateful, but not in serverless: https://observability-docs_bk_4593.docs-preview.app.elstc.co/guide/en/serverless/current/observability-synthetics-mfa.html.
(So does this topic, but I think it's appropriate given that "project" is an overloaded term: https://observability-docs_bk_4593.docs-preview.app.elstc.co/guide/en/serverless/current/observability-synthetics-configuration.html)
Co-authored-by: DeDe Morton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming build passes, of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Applies the updated APM information architecture introduced in #4230 to serverless docs.
Notable differences
Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
N/A
Checklist
Follow-up tasks
Select one.