Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES-8187] ES|QL elastic/logs scale testing challenge #618

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[ES-8187] ES|QL elastic/logs scale testing challenge #618

wants to merge 14 commits into from
+227 −2

Conversation

favilo
Copy link
Contributor

@favilo favilo commented Jun 13, 2024

Adding special queries specifically for scale testing ESQL queries

@bpintea bpintea self-requested a review June 17, 2024 10:28
bpintea
bpintea reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments mostly concerning queries that might no longer be needed.
I think it'd be great if we only have those queries present that we want timing details about.

elastic/logs/operations/esql.json Outdated Show resolved Hide resolved
elastic/logs/operations/esql.json Outdated Show resolved Hide resolved
elastic/logs/operations/esql.json Outdated Show resolved Hide resolved
@gbanasiak
Copy link
Contributor

@favilo I've modified queries in 3747188 to reduce response time but hard-coded timestamp is problematic. I don't think this should land in master branch.

craigtaverner
craigtaverner approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I wonder were all four of these really long running? If not, we should not push the iteration count down for fast queries.

@gbanasiak
Copy link
Contributor

I wonder were all four of these really long running?

Yes.

@gbanasiak
Copy link
Contributor

#705 includes the queries from this PR, so I'll rework it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea left review comments

@craigtaverner craigtaverner craigtaverner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@favilo @gbanasiak @craigtaverner @bpintea