-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm/trivy-operator to 0.26.0 and trivy-operator to 0.24.0 #2418
base: main
Are you sure you want to change the base?
Conversation
The helm chart defaults to trivy-operator version v0.23.0
3c9eee4
to
d288099
Compare
@@ -39,9 +33,9 @@ trivy: | |||
timeout: {{- toYaml .Values.trivy.scanner.timeout | nindent 4 }} | |||
{{- end }} | |||
|
|||
operator: | |||
useEmbeddedRegoPolicies: "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was false previously so I decided to keep it that way by overriding it here.
I don't see us using any policies in Trivy as it is now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look into
{"level":"error","ts":"2025-02-21T13:27:54Z","msg":"Reconciler error","controller":"job","controllerGroup":"batch","controllerKind":"Job","Job":{"name":"node-collector-76c989d645","namespace":"monitoring"},"namespace":"monitoring","name":"node-collector-76c989d645","reconcileID":"a4efb86a-60e8-46af-a01a-2779bc8d2bb6","error":"failed to evaluate policies on Node : failed to load rego checks from [externalPolicies]: stat externalPolicies: file does not exist","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:332\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:279\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller[...]).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:240"}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the override of the embedded policies to not have any job complain.
Updated to latest version of the helm chart and trivy-operator to resolve a few vulnerabilities in Trivy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
516ba8b
to
baea4c2
Compare
The helm chart defaults to trivy-operator version v0.24.0
baea4c2
to
78c9f29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- mirror.gcr.io/aquasec/node-collector | ||
- mirror.gcr.io/aquasec/trivy | ||
- mirror.gcr.io/aquasec/trivy-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, sort.
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
What does this PR do / why do we need this PR?
Upgrades Trivy-operator helm chart to version 0.26.0 which run Trivy-operator app version 0.24.0.
Information to reviewers
Checklist