Choose WAL-G backup by start time when cloning and deleting #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonklb
approved these changes
Dec 4, 2024
postgres-appliance/Dockerfile
Outdated
| ARG PGOLDVERSIONS="12 13 14 15" | ||
| ARG PGOLDVERSIONS="13 14 15" |
There was a problem hiding this comment.
What is the harm in leaving this equal to upstream? I'm thinking that it's better to align as much as possible.
There was a problem hiding this comment.
This was originally because I had some trouble building the image early on that seemed related to older versions, but that seems to have been fixed while rebasing, so can just drop that commit.
There was a problem hiding this comment.
Yes, let's go with as much upstream as possible
OlleLarsson
approved these changes
Dec 9, 2024
lucianvlad
approved these changes
Dec 10, 2024
Zash
force-pushed
the
ka/choose-backup-by-start-time
branch
from
86dee27 to
7110177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1 with a rebased commit stack.
Fixes https://github.com/elastisys/compliantkubernetes-postgresql/issues/241
Also fixes the following upstream issues AFAIK (more investigation needed to verify):
Does not fix when Spilo relies on
wal-g backup-list LATEST:Breaks cloning from backup that does not include
metadata.json(for example backup created withwal-e):