-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and CI #2
base: main
Are you sure you want to change the base?
Conversation
Locate code according to best practices (https://github.com/golang-standards/project-layout)
@eleby, Could you please review this PR? 🙏🏻 |
Of course ! Thanks for the PR ! 😉 |
NAME=pixelizer | ||
|
||
SHELL := env DOCKER_REPO=$(DOCKER_REPO) $(SHELL) | ||
DOCKER_REPO?=eu.gcr.io/melsoft-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about dockers and makefiles, but doesn't this mean we won't be able to compile if this docker repo is down someday ? Also, it seems this repo has the name of your company. I don't know if it is relevant to use your company's docker repo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mark this as resolved please provide an answer about it so I can know if you will fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added lots of things I really don't know about;
Could you update the readme to write a doc about the functionnalities that were added ? It seems like the installation and compilation are completely different with this version, I am a little lost. I'd love to have time to learn about every tool you added and especially what they change in the program use but I don't unfortunately :/
Anyway, great job about all these changes. Can't wait for these informations and the answers to my comments !
You're always welcome;) Thanks for your review! You can check example of releases how they will be look) |
Okay ! So -sorry again for being a beginner in these aspects-, how does it work ? I will wait for your explanations, readme update and fix on the docker package line. I like the idea of improved releases, I hope to understand everything better so I can merge the PR. |
With this PR I add the following enhancements:
PS more refactor in next PRs