Skip to content

Commit

Permalink
AVO-669: Quick Fix: Center date between Time Header nav arrows (#7510)
Browse files Browse the repository at this point in the history
* feat: center date between timeheader nav arrows

* feat: use centered TimeHeader for aggregate views
  • Loading branch information
cadeban authored Dec 3, 2024
1 parent b527965 commit 0c86814
Showing 1 changed file with 71 additions and 64 deletions.
135 changes: 71 additions & 64 deletions web/src/features/time/HistoricalTimeHeader.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import Badge from 'components/Badge';
import { Button } from 'components/Button';
import {
NewFeaturePopover,
Expand Down Expand Up @@ -76,82 +75,90 @@ export default function HistoricalTimeHeader() {
navigate({ datetime: newDate.toISOString() });
}

return (
<div className="flex min-h-6 flex-row items-center justify-between">
{startDatetime && endDatetime && (
<Badge
pillText={
<FormattedTime
datetime={startDatetime}
language={i18n.languages[0]}
endDatetime={endDatetime}
/>
}
type="success"
if (!isHourly && startDatetime && endDatetime) {
return (
<div className="flex min-h-6 flex-row items-center justify-center">
<FormattedTime
datetime={startDatetime}
language={i18n.languages[0]}
endDatetime={endDatetime}
className="text-sm font-semibold"
/>
)}
{isHourly && (
<div className="flex h-6 flex-row items-center gap-x-3">
<NewFeaturePopover
side="top"
content={<NewFeaturePopoverContent />}
isOpenByDefault={isNewFeaturePopoverEnabled}
>
<Button
backgroundClasses="bg-transparent"
onClick={handleLeftClick}
size="sm"
type="tertiary"
isDisabled={!isWithinHistoricalLimit}
icon={
<ChevronLeft
size={22}
className={twMerge(
'text-brand-green dark:text-success-dark',
!isWithinHistoricalLimit && 'opacity-50'
)}
/>
}
/>
</NewFeaturePopover>
</div>
);
}

return (
<div className="relative flex h-6 w-full items-center">
<div className="absolute flex w-full items-center justify-between px-10">
<NewFeaturePopover
side="top"
content={<NewFeaturePopoverContent />}
isOpenByDefault={isNewFeaturePopoverEnabled}
>
<Button
backgroundClasses="bg-transparent"
onClick={handleLeftClick}
size="sm"
onClick={handleRightClick}
type="tertiary"
isDisabled={!urlDatetime}
isDisabled={!isWithinHistoricalLimit}
icon={
<ChevronRight
className={twMerge(
'text-brand-green dark:text-success-dark',
!urlDatetime && 'opacity-50'
)}
<ChevronLeft
size={22}
/>
}
/>
<Button
size="sm"
type="tertiary"
onClick={() => {
trackEvent(TrackEvent.HISTORICAL_NAVIGATION, {
direction: 'latest',
});
navigate({ datetime: '' });
}}
isDisabled={!urlDatetime}
icon={
<ArrowRightToLine
className={twMerge(
'text-brand-green dark:text-success-dark',
!urlDatetime && 'opacity-50'
!isWithinHistoricalLimit && 'opacity-50'
)}
size={22}
/>
}
/>
</div>
)}
</NewFeaturePopover>
{startDatetime && endDatetime && (
<FormattedTime
datetime={startDatetime}
language={i18n.languages[0]}
endDatetime={endDatetime}
className="text-sm font-semibold"
/>
)}
<Button
backgroundClasses="bg-transparent"
size="sm"
onClick={handleRightClick}
type="tertiary"
isDisabled={!urlDatetime}
icon={
<ChevronRight
className={twMerge(
'text-brand-green dark:text-success-dark',
!urlDatetime && 'opacity-50'
)}
size={22}
/>
}
/>
</div>
<Button
backgroundClasses="absolute z-1 right-2"
size="sm"
type="tertiary"
onClick={() => {
trackEvent(TrackEvent.HISTORICAL_NAVIGATION, {
direction: 'latest',
});
navigate({ datetime: '' });
}}
isDisabled={!urlDatetime}
icon={
<ArrowRightToLine
className={twMerge(
'text-brand-green dark:text-success-dark',
!urlDatetime && 'opacity-50'
)}
size={22}
/>
}
/>
</div>
);
}

0 comments on commit 0c86814

Please sign in to comment.