Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: path comparison in e sync #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: path comparison in e sync #622

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Supersedes #589

@codebytere @andrewsml
fix: path comparison in e sync
91b9cbf 
Co-authored-by: Andrew Kozlov <[email protected]>
@codebytere codebytere requested review from ckerr and a team as code owners July 25, 2024 09:06
MarshallOfSound
MarshallOfSound reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

> path.relative('/Users/', '/users/')
'../users'

I don't think this does what we want 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @ckerr @MarshallOfSound