test: use RTL in the welcome tour tests #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
changed the title
erikian
force-pushed
the
test/tour-rtl
branch
from
d938e9c
to
047f196
Compare
BlackHole1
approved these changes
Oct 24, 2023
erickzhao
approved these changes
Nov 2, 2023
erikian
force-pushed
the
test/tour-rtl
branch
from
4f871de
to
7b663a7
Compare
|
Merging as the Coveralls failure on the Linux build is fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #1408. This should be easier to review one commit at a time, as Github doesn't seem to be picking up the move across folders.
I removed the window resizing tests from
tour.spec.tsxas it's not possible to access the component state in RTL (it's an implementation detail) and I didn't figure out a way to test that using something a user could see and interact with.