refactor: finish splitting ElectronTypes to main process #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
refactor-electron-types-2
branch
from
fe9f948
to
8031db4
Compare
erikian
approved these changes
Aug 16, 2023
dsanders11
force-pushed
the
refactor-electron-types-2
branch
from
8031db4
to
636e784
Compare
ckerr
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1428 which finishes moving our Electron types code to the main process.
The only big change as a part of this refactoring is to the file watcher for local builds types. Since it is in the main process now, it has been streamlined to have one watcher per local build, and it keeps track of which windows need to be notified of changes to that path.