refactor: enable context isolation #1453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1452 so in draft mode until that lands.Only a couple of changes needed:
RunnableVersion
up to the callers ofwindow.ElectronFiddle
functions - these are proxies since they're observable by MobX and you can't clone proxies across the context isolation interfaceapp
andmonaco
off ofwindow.ElectronFiddle
as they're set during initialization inside the renderer process andwindow.ElectronFiddle
has read-only properties once context isolation is enabled