Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable context isolation #1453

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Aug 29, 2023

Stacked on top of #1452 so in draft mode until that lands.

Only a couple of changes needed:

  • Had to push destructuring RunnableVersion up to the callers of window.ElectronFiddle functions - these are proxies since they're observable by MobX and you can't clone proxies across the context isolation interface
  • Had to move app and monaco off of window.ElectronFiddle as they're set during initialization inside the renderer process and window.ElectronFiddle has read-only properties once context isolation is enabled

@coveralls
Copy link

coveralls commented Aug 29, 2023

Coverage Status

coverage: 87.085%. remained the same when pulling 1b1680b on enable-context-isolation into 57b50d4 on main.

@dsanders11 dsanders11 marked this pull request as ready for review September 11, 2023 04:45
@dsanders11 dsanders11 requested review from codebytere and a team as code owners September 11, 2023 04:45
@felixrieseberg
Copy link
Member

Thanks for your hard work!

forge.config.ts Outdated Show resolved Hide resolved
@dsanders11 dsanders11 merged commit 186fb60 into main Sep 12, 2023
3 checks passed
@dsanders11 dsanders11 deleted the enable-context-isolation branch September 12, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants