Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Progress Bar #280

Closed
wants to merge 1 commit into from
Closed

Download Progress Bar #280

wants to merge 1 commit into from

Conversation

botPuneet
Copy link

Created PR to resolve issue #issue

@botPuneet botPuneet requested a review from a team as a code owner April 7, 2024 17:25
@dsanders11
Copy link
Member

Thanks for the PR, but I don't think this is the right approach to solving electron/fiddle-core#59. @marfgold1 has shown the bug is due to redirects and invalid values for total. This PR would lead to NaN in those cases.

@dsanders11 dsanders11 closed this Apr 7, 2024
@botPuneet
Copy link
Author

Sorry @dsanders11 sir i have misunderstood the problem. thank u for the feedback. just one question is this issue still open?

Thanks for the PR, but I don't think this is the right approach to solving electron/fiddle-core#59. @marfgold1 has shown the bug is due to redirects and invalid values for total. This PR would lead to NaN in those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants