Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Use deep flag 😋 #240 #303

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ Build version of Electron.
Values may be like: `1.1.1`, `1.2.0`.
Default to latest Electron version.

`useDeepFlag` - *Boolean*

Flag to `codesign --deep` All signing options will be applied, in turn, to all nested content. Warn: **(DEPRECATED for signing as of macOS 13.0) When signing a bundle, specifies that nested code content such as helpers, frameworks, and plug-ins, should be recursively signed in turn.** to see more content, please execute `man codesign` in the terminal.
Default to `false`.

It is recommended to utilize this option for best support of specific Electron versions. This may trigger pre/post operations for signing: For example, automation of setting `com.apple.security.application-groups` in entitlements file and of updating `Info.plist` with `ElectronTeamID` is enabled for all versions starting from `1.1.1`; set `preAutoEntitlements` option to `false` to disable this feature.

#### From the Command Line
Expand Down
3 changes: 3 additions & 0 deletions src/sign.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ async function signApplication (opts: ValidatedSignOptions, identity: Identity)
if (opts.keychain) {
args.push('--keychain', opts.keychain);
}
if (opts.useDeepFlag) {
args.push('--deep');
}

/**
* Sort the child paths by how deep they are in the file tree. Some arcane apple
Expand Down
1 change: 1 addition & 0 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ type OnlySignOptions = {
strictVerify?: boolean;
type?: SigningDistributionType;
version?: string;
useDeepFlag?: boolean;
};

type OnlyValidatedSignOptions = {
Expand Down