Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow join unmuted in widget mode #2848

Draft
wants to merge 13 commits into
base: livekit
Choose a base branch
from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Nov 28, 2024

No description provided.

Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three things:

  • the test doesn't pass
  • I think there is a simpler way to do this just at the UrlParams level
  • the documentation update is missing.

As I am off today I will do a quick alternative PR.

src/room/MuteStates.ts Outdated Show resolved Hide resolved
@hughns
Copy link
Member

hughns commented Nov 29, 2024

Actually, I've run out of time to do something today. What I noticed was that the URL parameters were not being parsed from the mocked router URL.

@hughns hughns changed the title allow join unmuted in widget mode Allow join unmuted in widget mode Nov 29, 2024
@toger5
Copy link
Contributor Author

toger5 commented Nov 29, 2024

Thanks for the finding about the router URL.
The tests work locally lets see what i have setup differently!

src/room/MuteStates.ts Outdated Show resolved Hide resolved
@toger5
Copy link
Contributor Author

toger5 commented Jan 10, 2025

This already checks that the widget is started in widget mode.
Hence the way it is now, it would not introduce the risk of allowing to share a unmuted link.

@hughns
Copy link
Member

hughns commented Jan 10, 2025

Following discussion: marking draft until we revisit this topic as part of expected flows for telephone/DM use cases.

@hughns hughns marked this pull request as draft January 10, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Product More input needed from the Product team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants