Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenGraph and Twitter meta tags for better link previews #3006

Open
wants to merge 4 commits into
base: livekit
Choose a base branch
from

Conversation

Harshal-Taori-11
Copy link

Fix #2191

@Harshal-Taori-11 Harshal-Taori-11 requested a review from a team as a code owner February 13, 2025 16:06
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we're certainly interested in having OpenGraph tags like this. The application can be configured to use a brand name other than "Element Call" via the VITE_PRODUCT_NAME environment variable, so the main thing we'd like to see here is that the OpenGraph tags respect this variable by template-ing it in.

I'd also suggest leaving the 'URL' and 'domain' tags out of the metadata entirely because we want our builds to be something you can easily download from GitHub and host on your own server without any references to our call.element.io deployment. I'm not too familiar with OpenGraph, is it possible to just not set those without breaking link previews?

@Harshal-Taori-11
Copy link
Author

Hi, yes I will make changes.

I think we can remove those tags.So I will remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Opengraph tags for third parties to generate previews
3 participants