Skip to content

Set the correct license on docker images #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

hughns
Copy link
Member

@hughns hughns commented Apr 11, 2025

Previously the docker/metadata action was autodetecting the license and only getting AGPL not dual license.

Previously the docker/metadata action was autodetecting the license and only getting AGPL not dual license.
@hughns
Copy link
Member Author

hughns commented Apr 11, 2025

Currently I have no way to test this PR in our CI.

This is because the pr-deploy.yaml workflow (which in turn calls the build-and-publish-docker.yaml workflow) is triggered by the completion of the build.yaml workflow. This means that pr-deploy.yaml is always run from the default (i.e. livekit) branch and in turn the build-and-publish-docker.yaml is run from livekit.

This is sub-optimal.

To fix could:

  • combine the pr-deploy.yaml steps into the build.yaml directly
  • call pr-deploy.yaml from build.yaml explicitly

In the meantime I'm going to just merge this PR and test on livekit branch.

@hughns hughns marked this pull request as ready for review April 11, 2025 16:57
@hughns hughns requested a review from fkwp April 11, 2025 16:58
@hughns hughns enabled auto-merge (squash) April 11, 2025 16:58
Copy link
Contributor

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hughns hughns merged commit f5615f2 into livekit Apr 11, 2025
29 checks passed
@hughns hughns deleted the hughns/docker-spdx branch April 11, 2025 17:01
@hughns
Copy link
Member Author

hughns commented Apr 11, 2025

This is working in so far as the expected licenses label is appearing in https://github.com/element-hq/element-call/actions/runs/14408255425/job/40410011160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants