Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Burn Node-related Electron fuses as a proactive hardening measure #1412

Merged
merged 24 commits into from
Jan 9, 2024
Merged

Burn Node-related Electron fuses as a proactive hardening measure #1412

merged 24 commits into from
Jan 9, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 3, 2024 •
edited by github-actions bot
Loading

Fixes https://github.com/matrix-org/internal-config/issues/1495

Here's what your changelog entry will look like:

✨ Features

  • Burn Node-related Electron fuses as a proactive hardening measure (#1412). Fixes matrix-org/internal-config#1495.

t3chguy added 5 commits January 2, 2024 12:41
@t3chguy
Move electron-builder config to typescript file
b5b6570 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Replace generate-builder-config.ts with electron-builder.ts
e545f44 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Burn in Electron fuses to tighten security parameters
60f69fa 
See https://www.electronjs.org/docs/latest/tutorial/fuses

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Handle Linux better
1e9320b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-desktop …
48a5ee5 
…into t3chguy/electron-fuses

Signed-off-by: Michael Telatynski <[email protected]>

# Conflicts:
#	.github/workflows/build_windows.yaml
#	yarn.lock
t3chguy added 8 commits January 3, 2024 17:23
@t3chguy
Fix fuse setting for Linux packages
3a75b9c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Re-enable fuse EnableNodeCliInspectArguments for playwright test CI
35150a5 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Set fuse in test code itself
994678f 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix executable paths
97e639f 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
SUDO
fb09900 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix macOS test
ceda9ee 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
DEBUG
b5664e3 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
DEBUG2
c7a121f 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy changed the title Burn in Electron fuses to tighten security parameters Burn Node-related Electron fuses as a proactive hardening measure Jan 4, 2024
t3chguy and others added 8 commits January 4, 2024 09:58
@t3chguy
DEBUG3
edcd578 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
DEBUG4
12c1f26 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
DEBUG5
53a657e 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
DEBUG6
9b1d7a1 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
DEBUG7
86e854a 
Signed-off-by: Michael Telatynski <[email protected]>
@BillCarsonFr @t3chguy
DEBUG8
8f5dc50 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Try without ~
c884316 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Remove debug
8d2d433 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review January 4, 2024 16:43
@t3chguy t3chguy requested review from a team as code owners January 4, 2024 16:43
richvdh
richvdh requested changes Jan 4, 2024
View reviewed changes
.github/workflows/build_and_test.yaml Show resolved Hide resolved
electron-builder.js Outdated Show resolved Hide resolved
electron-builder.js Outdated Show resolved Hide resolved
.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
electron-builder.js Outdated Show resolved Hide resolved
electron-builder.js Outdated Show resolved Hide resolved
electron-builder.js Outdated Show resolved Hide resolved
@t3chguy
Iterate
a3a7e85 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested a review from richvdh January 5, 2024 09:27
richvdh
richvdh approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

.github/workflows/build_and_test.yaml Outdated Show resolved Hide resolved
@t3chguy t3chguy enabled auto-merge (squash) January 5, 2024 16:56
@t3chguy t3chguy disabled auto-merge January 9, 2024 15:55
@t3chguy t3chguy merged commit b479798 into develop Jan 9, 2024
24 checks passed
@t3chguy t3chguy deleted the t3chguy/electron-fuses branch January 9, 2024 15:56
@t3chguy t3chguy mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from element-hq/element-web-team

Assignees
No one assigned
Labels
Security T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @richvdh @BillCarsonFr