-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Smart App Banner to prompt users to download the native iOS app #21763
Comments
I wonder if the smart banner can work dynamically, because we can't hardcode it into index.html as the iOS app being pointed to may be the wrong one depending on the deployment - and given Element is all static files, would need to be injected after reading config.json |
https://stackoverflow.com/questions/31289530/load-ios-smart-app-banner-through-javascript claims it doesn't work if injected async, but is rather old so may no longer be the case |
Figma example of smart app banners. Think we should do this. |
As per my comments above, the smart app banner for iOS may not be possible due to the async nature of our purely client-side SPA config mechanisms (config.json is read by the client, not injected by the server) - but does need more testing by someone with an iOS device. |
@gsouquet that PR didn't add any such thing 😇 |
I think another issue is that some iOS browsers (cough iPadOS) lie and claim to be a desktop browser, so the app banner won't be shown as the user won't be taken to the mobile_guide |
@t3chguy it definitely did, look at
Yes that is an issue, but that is not part of this and should be tackled as part of #14962 and #15035 |
Yes, after being removed from a few lines lower, by the auto-formatter |
Your use case
What would you like to do?
Add Smart App Banner to prompt users to download the native iOS app from the App Store.
Why would you like to do it?
Element Web on mobile is unusable and marked as experimental.
How would you like to achieve it?
See the Implement a Smart App Banner on Your Website section on https://developer.apple.com/documentation/webkit/promoting_apps_with_smart_app_banners
Have you considered any alternatives?
No response
Additional context
Full context for improving the first time user experience for iOS users: matrix-org/matrix.to#263
The text was updated successfully, but these errors were encountered: