-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toast for recovery keys being out of sync #28946
Merged
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
3e77b3d
Refine `SettingsSection` & `SettingsTab`
florianduros ae623f8
Add encryption tab
florianduros f9e48b4
Add recovery section
florianduros 0057f57
Add device verification
florianduros bb507b0
Rename `Panel` into `State`
florianduros 1aace3f
Update & add tests to user settings common
florianduros 70c084e
Add tests to `RecoveryPanel`
florianduros 7193998
Add tests to `ChangeRecoveryKey`
florianduros fec324e
Update CreateSecretStorageDialog-test snapshot
florianduros 44c6bce
Add tests to `EncryptionUserSettingsTab`
florianduros 075f6dc
Update existing screenshots of e2e tests
florianduros 895ad88
Add new encryption tab ownership to `@element-hq/element-crypto-web-r…
florianduros ba032a7
Add e2e tests
florianduros 7909ac9
Fix monospace font and add figma link to hardcoded value
florianduros 618557c
Add unit to Icon
florianduros c805cd8
Merge branch 'develop' into florianduros/encryption-tab
florianduros 7a372f7
Merge branch 'develop' into florianduros/encryption-tab
florianduros b20579d
Improve e2e doc
florianduros 24c537c
Assert that the crypto module is defined
florianduros 72adfa5
Add classname doc
florianduros 36c7e0e
Fix typo
florianduros 52076f1
Use `good` state instead of default
florianduros a0d904e
Rename `ChangeRecoveryKey.isSetupFlow` into `ChangeRecoveryKey.userHa…
florianduros 1a0e6dc
Move `deleteCachedSecrets` fixture in `recovery.spec.ts`
florianduros 0b254e5
Use one callback instead of two in `RecoveryPanel`
florianduros 6f236bd
Fix docs and naming of `utils.createBot`
florianduros 82bf2cc
Fix typo in `RecoveryPanel`
florianduros 84d11f8
Add more doc to the state of the `EncryptionUserSettingsTab`
florianduros 2fe5555
Rename `verification_required` into `set_up_encryption`
florianduros 4b365ba
Merge branch 'develop' into florianduros/encryption-tab
florianduros 8a9291a
Update test
florianduros 1c00502
ADd new license
florianduros d9d7528
Very early WIP of rejigged e2e error toast code
dbkr dc940f5
Update comments and doc
florianduros 521cebf
Assert that `recoveryKey.encodedPrivateKey` is always defined
florianduros 7af44cc
Add comments to explain how the secrets could be uncached
florianduros 8bd5d6a
Use `matrixClient.secretStorage.getDefaultKeyId` instead of `matrixCl…
florianduros 086f28e
Merge branch 'develop' into florianduros/encryption-tab
florianduros 0c18708
Update existing screenshot to add encryption tab.
florianduros 484b2af
Fix tests
dbkr ef76454
Remove unused file!
dbkr 7a55d83
Remove test for unused file
dbkr 9a7f568
Show 'set up encryption' in the 'other' case.
dbkr 33967d4
Test 'key storage out of sync' toast
dbkr 0a52b7c
Update tests
florianduros cb43672
Fix test & make toast look correct
dbkr e5dea48
Use new labels when changing the recovery key
florianduros b7b7a98
Merge branch 'florianduros/encryption-tab' into dbkr/e2e_toasts
dbkr f78c27a
Fix docs
florianduros bef3165
Don't reset key backup when creating a recovery key
florianduros 0a6db75
Merge branch 'florianduros/encryption-tab' into dbkr/e2e_toasts
dbkr 9243ae1
Merge remote-tracking branch 'origin/develop' into dbkr/e2e_toasts
dbkr 82ec6ae
Add playwright test for toast
dbkr 1934145
Dismiss the toast as it's now in the way due to being wider
dbkr 57e9c31
Doesn't look like this needs to be async
dbkr 3649b07
Typo
dbkr 5bf0d2d
Typo
dbkr 2c3896c
Override width for just this toast
dbkr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix tests
- Loading branch information
commit 484b2af9d8ff7cd711161054cee26112fd01741c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear why this test was testing this... I don't really understand why it would be important that it did this. Maybe in some circumstances it should, but if so shouldn't we be testing to see if it prompts you to set up key backup or whatever w're expecting?