Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up modules #29089

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Tidy up modules #29089

merged 1 commit into from
Jan 27, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 24, 2025

Media shouldn't constructed directly as a customisation is allowed to change its constructor interface

modules.ts was a mess being in TS but not existing until after a build, so I swapped it to a js file with a d.ts typing

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added this pull request to the merge queue Jan 27, 2025
Merged via the queue into develop with commit c390ec3 Jan 27, 2025
42 checks passed
@t3chguy t3chguy deleted the t3chguy/tidy-up-modules branch January 27, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants